removes unnecessary allocations in shreds ingestion path #4530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
rm-shreds-ingest-allocs
branch
2 times, most recently
from
d9e5512 to
c1b1ef1
Compare
behzadnouri
force-pushed
the
rm-shreds-ingest-allocs
branch
2 times, most recently
from
fad5cb1 to
482b9db
Compare
Ingesting shreds unnecessarily allocates a HashSet to remove invalid repair-meta: https://github.com/anza-xyz/agave/blob/0f56076a2/core/src/window_service.rs#L250 and a separate vector for repair flags: https://github.com/anza-xyz/agave/blob/0f56076a2/core/src/window_service.rs#L338-L341 Similarly Blockstore::insert_shreds (called in broadcast-stage to insert own shreds during leader slots), allocates a vector for repair flags: https://github.com/anza-xyz/agave/blob/0f56076a2/ledger/src/blockstore.rs#L1381 All can be avoided if blockstore insert_shreds api are updated to take an argument of type shreds: impl ExactSizeIterator<Item = (Shred, /*is_repaired:*/ bool)>,
behzadnouri
force-pushed
the
rm-shreds-ingest-allocs
branch
from
482b9db to
22ab610
Compare
carllin
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ingesting shreds unnecessarily allocates a
HashSetto remove invalid repair-meta:https://github.com/anza-xyz/agave/blob/0f56076a2/core/src/window_service.rs#L250
and a separate vector for repair flags:
https://github.com/anza-xyz/agave/blob/0f56076a2/core/src/window_service.rs#L338-L341
Similarly
Blockstore::insert_shreds(called in broadcast-stage to insert own shreds during leader slots), allocates a vector for repair flags:https://github.com/anza-xyz/agave/blob/0f56076a2/ledger/src/blockstore.rs#L1381
All can be avoided if blockstore
insert_shreds...api are updated to take an argument of typeSummary of Changes
Removed unnecessary allocations in shreds ingestion path.