Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: inflation rewards Reward Slot no longer accurate for multiple accounts #3984

Open
CriesofCarrots opened this issue Dec 6, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@CriesofCarrots
Copy link

Problem

Now that the Partitioned Epoch Rewards feature is active, stake accounts receive their rewards across a range of slots, instead of all in the same slot. The RPC getInflationReward accepts multiple stake-account addresses and returns the correct effective slot for each account/reward. But the solana-cli assumes the effective slot for the first reward applies to all accounts queried (CliEpochRewardsMetadata::effective_slot). When --output json is passed, the return includes the correct effectiveSlot within each reward struct, but also includes an incorrect effectiveSlot at the top level.

Proposed Solution

Deprecate CliEpochRewardsMetadata::effective_slot
In human-readable mode, display Reward Slot in each reward line

@CriesofCarrots CriesofCarrots added the good first issue Good for newcomers label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant