Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Http headers for RPC and PubSub Clients #3915

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Http headers for RPC and PubSub Clients #3915

wants to merge 2 commits into from
+447 −14

Conversation

ozanselte
Copy link

@ozanselte ozanselte commented Dec 4, 2024 •
edited
Loading

Problem

Some RPC and WSS servers need specific HTTP headers. It is possible to solve the problem for RPC client but I could not find a way for WebSocket besides doing my own connections and requests. So here is the solution for those problems.

Summary of Changes

Added reqwest::header parameters for some methods.
Created new methods for rpc-client and added new parameters for pubsub-client.

Fixes #3917

@mergify mergify bot requested a review from a team December 4, 2024 15:02
@ozanselte ozanselte mentioned this pull request Dec 4, 2024
Open
@t-nelson
Copy link

this cannot be accepted as is. it breaks public api. i'd recommend a strategy similar to the RpcClient::new_sender interface, but it's going to be major surgery

@ozanselte
Copy link
Author

Yes this PR breaks PubSubClient but I did not get it how does it break RpcClient library?
Since this PR is not merged, I am using new_sender on my projects.
@t-nelson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community need:merge-assist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clients do not allow custom HTTP headers
2 participants
@ozanselte @t-nelson