Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making DbObject more idiomatic #39

Open
mikolak-net opened this issue Apr 19, 2016 · 2 comments
Open

Making DbObject more idiomatic #39

mikolak-net opened this issue Apr 19, 2016 · 2 comments

Comments

@mikolak-net
Copy link

The DbObject helper trait has several "non-Scalastic" qualities:

  • the underlying, mutable Vertex is exposed via getVertex (especially problematic since DbObject seems to be intended to be mixed into case classes),
  • most of the utility methods are "expression unfriendly" (return Unit).

Obviously, there needs to be a way to interface with the "main" blueprints API, but is there a reason for this particular implementation?

I would be very happy to produce a PR with a more idiomatic approach, but I'd like to understand the rationale for the status quo first.

@anvie
Copy link
Owner

anvie commented Apr 21, 2016

There is no specific reason for that implementation, you are welcome to provide a PR, I'll love to review :)

@mikolak-net
Copy link
Author

Excellent, I'll get to it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants