Release (#1908)

wang1212 · github-actions[bot] · web-flow · commit c17534be4117 · 2025-02-27T16:25:13.000+08:00
* fix: image element rendering triggers an exception (#1906) * fix: image element rendering triggers an exception * chore: add image bugfix demo #1906 * chore(release): bump version (#1907) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -49,6 +49,7 @@ module.exports = {
     'import/no-cycle': 'warn',
     'import/no-duplicates': 'warn',
     'class-methods-use-this': 'warn',
+    'no-console': ['warn', { allow: ['warn', 'error'] }],
     'no-plusplus': [
       'warn',
       {
diff --git a/__tests__/demos/bugfix/1906.ts b/__tests__/demos/bugfix/1906.ts
@@ -0,0 +1,33 @@
+import { Canvas, Image as GImage } from '@antv/g';
+
+/**
+ * @see https://github.com/antvis/G/pull/1906
+ */
+export async function issue_1906(context: { canvas: Canvas }) {
+  const { canvas } = context;
+  await canvas.ready;
+  canvas.context.config.enableLargeImageOptimization = true;
+
+  const img = new Image();
+  img.onload = () => {
+    console.log('onload', img.complete);
+
+    // remove && expect no error
+    requestAnimationFrame(() => {
+      image.remove();
+    });
+  };
+
+  let image = new GImage({
+    style: {
+      x: 0,
+      y: 0,
+      src: img,
+    },
+  });
+
+  img.src =
+    'https://mdn.alipayobjects.com/huamei_fr7vu1/afts/img/A*SqloToP7R9QAAAAAAAAAAAAADkn0AQ/original';
+
+  canvas.appendChild(image);
+}
diff --git a/__tests__/demos/bugfix/index.ts b/__tests__/demos/bugfix/index.ts
@@ -10,6 +10,7 @@ export { test_pick } from './1747';
 export { issue_1760 } from './1760';
 export { issue_1176 } from './1176';
 export { issue_1882 } from './1882';
+export { issue_1906 } from './1906';
 export { textWordWrap } from './textWordWrap';
 export { group_with_stroke } from './group-with-stroke';
 export { switchRenderer } from './switch-renderer';
diff --git a/packages/g-canvas/CHANGELOG.md b/packages/g-canvas/CHANGELOG.md
@@ -1,5 +1,14 @@
 # @antv/g-canvas
 
+## 2.0.40
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-canvas-renderer@2.2.19
+    -   @antv/g-plugin-image-loader@2.1.19
+    -   @antv/g-plugin-canvas-picker@2.1.19
+
 ## 2.0.39
 
 ### Patch Changes
diff --git a/packages/g-canvas/package.json b/packages/g-canvas/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-canvas",
-  "version": "2.0.39",
+  "version": "2.0.40",
   "description": "A renderer implemented by Canvas 2D API",
   "keywords": [
     "antv",
diff --git a/packages/g-canvaskit/CHANGELOG.md b/packages/g-canvaskit/CHANGELOG.md
@@ -1,5 +1,14 @@
 # @antv/g-canvaskit
 
+## 1.0.39
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-image-loader@2.1.19
+    -   @antv/g-plugin-canvas-picker@2.1.19
+    -   @antv/g-plugin-canvaskit-renderer@2.1.19
+
 ## 1.0.38
 
 ### Patch Changes
diff --git a/packages/g-canvaskit/package.json b/packages/g-canvaskit/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-canvaskit",
-  "version": "1.0.38",
+  "version": "1.0.39",
   "description": "A renderer implemented by CanvasKit",
   "keywords": [
     "antv",
diff --git a/packages/g-mobile-canvas/CHANGELOG.md b/packages/g-mobile-canvas/CHANGELOG.md
@@ -1,5 +1,14 @@
 # @antv/g-mobile-canvas
 
+## 1.0.37
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-canvas-renderer@2.2.19
+    -   @antv/g-plugin-image-loader@2.1.19
+    -   @antv/g-plugin-canvas-picker@2.1.19
+
 ## 1.0.36
 
 ### Patch Changes
diff --git a/packages/g-mobile-canvas/package.json b/packages/g-mobile-canvas/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-mobile-canvas",
-  "version": "1.0.36",
+  "version": "1.0.37",
   "description": "A renderer implemented with Canvas2D API in mobile environment",
   "keywords": [
     "antv",
diff --git a/packages/g-mobile-webgl/CHANGELOG.md b/packages/g-mobile-webgl/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @antv/g-mobile-webgl
 
+## 1.0.44
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-image-loader@2.1.19
+    -   @antv/g-plugin-device-renderer@2.2.19
+
 ## 1.0.43
 
 ### Patch Changes
diff --git a/packages/g-mobile-webgl/package.json b/packages/g-mobile-webgl/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-mobile-webgl",
-  "version": "1.0.43",
+  "version": "1.0.44",
   "description": "A renderer implemented by WebGL1/2 in mobile environment",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-3d/CHANGELOG.md b/packages/g-plugin-3d/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @antv/g-plugin-3d
 
+## 2.0.42
+
+### Patch Changes
+
+-   @antv/g-plugin-device-renderer@2.2.19
+
 ## 2.0.41
 
 ### Patch Changes
diff --git a/packages/g-plugin-3d/package.json b/packages/g-plugin-3d/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-3d",
-  "version": "2.0.41",
+  "version": "2.0.42",
   "description": "Provide 3D extension for G",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-canvas-picker/CHANGELOG.md b/packages/g-plugin-canvas-picker/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @antv/g-plugin-canvas-picker
 
+## 2.1.19
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-canvas-renderer@2.2.19
+
 ## 2.1.18
 
 ### Patch Changes
diff --git a/packages/g-plugin-canvas-picker/package.json b/packages/g-plugin-canvas-picker/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-canvas-picker",
-  "version": "2.1.18",
+  "version": "2.1.19",
   "description": "A G plugin for picking in canvas",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-canvas-renderer/CHANGELOG.md b/packages/g-plugin-canvas-renderer/CHANGELOG.md
@@ -1,5 +1,13 @@
 # @antv/g-plugin-canvas-renderer
 
+## 2.2.19
+
+### Patch Changes
+
+-   cc62be4: fix: image element rendering triggers an exception
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-image-loader@2.1.19
+
 ## 2.2.18
 
 ### Patch Changes
diff --git a/packages/g-plugin-canvas-renderer/package.json b/packages/g-plugin-canvas-renderer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-canvas-renderer",
-  "version": "2.2.18",
+  "version": "2.2.19",
   "description": "A G plugin of renderer implementation with Canvas2D API",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-canvas-renderer/src/shapes/styles/Image.ts b/packages/g-plugin-canvas-renderer/src/shapes/styles/Image.ts
@@ -47,14 +47,19 @@ export class ImageRenderer extends DefaultRenderer {
     if (!imageCache.downSampled) {
       this.imagePool
         .createDownSampledImage(src, object)
-        .then((res) => {
+        .then(() => {
+          // be removed from dom tree
+          if (!object.ownerDocument) {
+            return;
+          }
+
           // rerender
           // object.dirty();
           object.renderable.dirty = true;
           object.ownerDocument.defaultView.context.renderingService.dirtify();
         })
-        .catch(() => {
-          //
+        .catch((reason) => {
+          console.error(reason);
         });
 
       return;
@@ -92,15 +97,20 @@ export class ImageRenderer extends DefaultRenderer {
           src,
           [],
           () => {
+            // be removed from dom tree
+            if (!object.ownerDocument) {
+              return;
+            }
+
             // rerender
             // object.dirty();
             object.renderable.dirty = true;
             object.ownerDocument.defaultView.context.renderingService.dirtify();
           },
           object,
         )
-        .catch(() => {
-          //
+        .catch((reason) => {
+          console.error(reason);
         });
 
       return;
@@ -244,7 +254,9 @@ export class ImageRenderer extends DefaultRenderer {
         imageRect,
         drawRect,
       });
-    } catch {}
+    } catch {
+      // expected error
+    }
   }
 
   // ---
diff --git a/packages/g-plugin-canvaskit-renderer/CHANGELOG.md b/packages/g-plugin-canvaskit-renderer/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @antv/g-plugin-canvaskit-renderer
 
+## 2.1.19
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-image-loader@2.1.19
+
 ## 2.1.18
 
 ### Patch Changes
diff --git a/packages/g-plugin-canvaskit-renderer/package.json b/packages/g-plugin-canvaskit-renderer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-canvaskit-renderer",
-  "version": "2.1.18",
+  "version": "2.1.19",
   "description": "A G plugin of renderer implementation with CanvasKit",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-device-renderer/CHANGELOG.md b/packages/g-plugin-device-renderer/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @antv/g-plugin-device-renderer
 
+## 2.2.19
+
+### Patch Changes
+
+-   Updated dependencies [cc62be4]
+    -   @antv/g-plugin-image-loader@2.1.19
+
 ## 2.2.18
 
 ### Patch Changes
diff --git a/packages/g-plugin-device-renderer/package.json b/packages/g-plugin-device-renderer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-device-renderer",
-  "version": "2.2.18",
+  "version": "2.2.19",
   "description": "A G plugin of renderer implementation with GPUDevice",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-image-loader/CHANGELOG.md b/packages/g-plugin-image-loader/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @antv/g-plugin-image-loader
 
+## 2.1.19
+
+### Patch Changes
+
+-   cc62be4: fix: image element rendering triggers an exception
+
 ## 2.1.18
 
 ### Patch Changes
diff --git a/packages/g-plugin-image-loader/package.json b/packages/g-plugin-image-loader/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-image-loader",
-  "version": "2.1.18",
+  "version": "2.1.19",
   "description": "A G plugin for loading image",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-image-loader/src/ImagePool.ts b/packages/g-plugin-image-loader/src/ImagePool.ts
@@ -85,8 +85,8 @@ export class ImagePool {
       .then((cache) => {
         callback?.(cache);
       })
-      .catch(() => {
-        //
+      .catch((reason) => {
+        console.error(reason);
       });
 
     return null;
diff --git a/packages/g-plugin-rough-canvas-renderer/CHANGELOG.md b/packages/g-plugin-rough-canvas-renderer/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @antv/g-plugin-rough-canvas-renderer
 
+## 2.0.40
+
+### Patch Changes
+
+-   @antv/g-canvas@2.0.40
+
 ## 2.0.39
 
 ### Patch Changes
diff --git a/packages/g-plugin-rough-canvas-renderer/package.json b/packages/g-plugin-rough-canvas-renderer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-rough-canvas-renderer",
-  "version": "2.0.39",
+  "version": "2.0.40",
   "description": "A G plugin of renderer implementation with rough.js",
   "keywords": [
     "antv",
diff --git a/packages/g-plugin-zdog-canvas-renderer/CHANGELOG.md b/packages/g-plugin-zdog-canvas-renderer/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @antv/g-plugin-zdog-canvas-renderer
 
+## 2.0.39
+
+### Patch Changes
+
+-   @antv/g-canvas@2.0.40
+
 ## 2.0.38
 
 ### Patch Changes
diff --git a/packages/g-plugin-zdog-canvas-renderer/package.json b/packages/g-plugin-zdog-canvas-renderer/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-plugin-zdog-canvas-renderer",
-  "version": "2.0.38",
+  "version": "2.0.39",
   "description": "A G plugin of renderer implementation with Zdog",
   "keywords": [
     "antv",
diff --git a/packages/g-web-components/CHANGELOG.md b/packages/g-web-components/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @antv/g-web-components
 
+## 2.0.46
+
+### Patch Changes
+
+-   @antv/g-canvas@2.0.40
+-   @antv/g-webgl@2.0.44
+
 ## 2.0.45
 
 ### Patch Changes
diff --git a/packages/g-web-components/package.json b/packages/g-web-components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@antv/g-web-components",
-  "version": "2.0.45",
+  "version": "2.0.46",
   "description": "A declarative usage for G implemented with WebComponents",
   "keywords": [
     "antv",
diff --git a/packages/g-webgl/CHANGELOG.md b/packages/g-webgl/CHANGELOG.md
diff --git a/packages/g-webgl/package.json b/packages/g-webgl/package.json
diff --git a/packages/g-webgpu/CHANGELOG.md b/packages/g-webgpu/CHANGELOG.md
diff --git a/packages/g-webgpu/package.json b/packages/g-webgpu/package.json

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ module.exports = {`
`49`	`49`	`'import/no-cycle': 'warn',`
`50`	`50`	`'import/no-duplicates': 'warn',`
`51`	`51`	`'class-methods-use-this': 'warn',`
	`52`	`+ 'no-console': ['warn', { allow: ['warn', 'error'] }],`
`52`	`53`	`'no-plusplus': [`
`53`	`54`	`'warn',`
`54`	`55`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@antv/g-canvas",`
`3`		`- "version": "2.0.39",`
	`3`	`+ "version": "2.0.40",`
`4`	`4`	`"description": "A renderer implemented by Canvas 2D API",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"antv",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@antv/g-canvaskit",`
`3`		`- "version": "1.0.38",`
	`3`	`+ "version": "1.0.39",`
`4`	`4`	`"description": "A renderer implemented by CanvasKit",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"antv",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@antv/g-mobile-canvas",`
`3`		`- "version": "1.0.36",`
	`3`	`+ "version": "1.0.37",`
`4`	`4`	`"description": "A renderer implemented with Canvas2D API in mobile environment",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"antv",`