Replies: 15 comments 44 replies
-
Most users want to get bug fixes and improvements without making big jumps such as changing jvm. |
Beta Was this translation helpful? Give feedback.
-
There would also be a benefit in releasing a Java 9 version in order fo benefit from Java modules. |
Beta Was this translation helpful? Give feedback.
-
At this point I'm ready to move to a newer version of java... Getting this to compile is driving me crazy! Perhaps we tell people that need much earlier versions to use 4.9.3 or earlier? |
Beta Was this translation helpful? Give feedback.
-
Ok, so I've been playing around and I'm using java 8, the lowest version I could find on Oracle's website. Everything works fine using source and target 1.7 so we might as well leave it. I remember the android people or something needed an old version of Java so why upgrade if we don't have to. We can build with any version we want but the target can be left at 1.7 I think. |
Beta Was this translation helpful? Give feedback.
-
Which is min version you recommend? jdk 8? that's easy to do as i have #3392 already in progress. |
Beta Was this translation helpful? Give feedback.
-
Pushed new change to mac/appveyor...hoping it'll fix. off to teach for 2 hours. |
Beta Was this translation helpful? Give feedback.
-
Yeah, weird. that exact thing works on my mac. Will mess with |
Beta Was this translation helpful? Give feedback.
-
Ok, we're back to passing! Well, linux times out on parsing tests for C++. :( Should we remove "Travis-CI Build Status (Swift-Linux)" since it seems out of date and we test swift on mac? |
Beta Was this translation helpful? Give feedback.
-
Ok, I have been able to get this to build now with 1.8 and 11 but with source and target 1.7 in the maven pom, so I'm going to leave it. See #3392 lots of incompatibility between the different versions and I don't want to make a maven file that is really sensitive to the Java version. This project is super complicated with all of the use of the internal javac tools.jar stuff that went away and now this module crap in java...ugh. |
Beta Was this translation helpful? Give feedback.
-
Originally the tests were in separate files, but that created a bit of a complexity coz you needed 4 files: grammar, input, errors, output
The comments approach make it possible to guarantee that a change only affects the corresponding test, which I like.
It also makes it encouraging to write more tests.
I’m pretty sure we can get this working with Java 8 for the runtime and Java 17 for the tool.
Right now I’m a bit busy, but happy to join efforts with Ivan sometime in the future.
… Le 8 déc. 2021 à 22:53, Terence Parr ***@***.***> a écrit :
First, I'd like to hear what @ericvergnaud <https://github.com/ericvergnaud> thinks but it ain't a hard no ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#3369 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJBDI3DV27UVLZ4SEWTUP7HVBANCNFSM5I6QQJWA>.
|
Beta Was this translation helpful? Give feedback.
-
Ok, my new galactic overlords can only use Java 11 at this time and must build from src not use jar. I'll rebuild tests to use resource files of some flavor and set src=11, target=8. |
Beta Was this translation helpful? Give feedback.
-
IMO the preferred stance would be allowing ANTLR to require the previous Java LTS version. Today the most recent LTS is Java 17 with the previous LTS being Java 11, thus ANTLR should be free to require Java 11. This creates a happy medium. |
Beta Was this translation helpful? Give feedback.
-
Ok, merged 3rd gen test rig. Compiles with java 17 it appears but set at 1.8 src/trg. Happy to have someone figure out how to make this 11 src, 7 or 8 trg. |
Beta Was this translation helpful? Give feedback.
-
Just to keep this thread up to date: current build after I merged the test rig update we are stuck at version 8 java for source and target. |
Beta Was this translation helpful? Give feedback.
-
@Techcable Yeah, I only test a few targets locally since I don't have all of those languages installed... I rely on the continuous integration to handle those other tests. |
Beta Was this translation helpful? Give feedback.
-
Java 7 support reaches the end in the middle of 2022: https://en.wikipedia.org/wiki/Java_version_history. Moreover, it's extended support, not even the base.
I suggest moving to the latest modern LTS Java, namely Java 17 that was released in September 2021. Also, it contains a lot of new features and API that could greatly improve developers' performance.
Beta Was this translation helpful? Give feedback.
All reactions