You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
eslint succeeds. Then I ran this to install a module with a name starting with a number:
pnpm add 3dmol
pnpm run lint
eslint succeeds. Then I ran this to run taze:
pnpm run up
pnpm run lint
and I get this:
❯ pnpm run lint
> @ lint C:\Users\DuncanLock\dev\vitesse-jsonc-sort-keys-repro
> eslint .=============WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.You may find that it works just fine, or you may not.SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.1.0YOUR TYPESCRIPT VERSION: 5.1.3Please only submit bug reports when using the officially supported version.=============C:\Users\DuncanLock\dev\vitesse-jsonc-sort-keys-repro\package.json 24:5 error Expected object keys to be in ascending order. '3dmol' should be before '@vueuse/head' jsonc/sort-keys✖ 1 problem (1 error, 0 warnings) 1 error and 0 warnings potentially fixable with the `--fix` option. ELIFECYCLE Command failed with exit code 1.
While running taze -w won't produce new dependencies, how about obeying the old order when writing into the package.json?
If it's ok, I would be pleasant to compose a PR. @antfu
Describe the bug
After running taze, I get this eslint error:
If I start with these dependencies:
after I run taze, they end up like this:
which causes the
jsonc/sort-key
linter error.Looks like taze is sorting numbers after symbols, whereas
jsonc/sort-key
is expecting symbols first.If you look at the reproduction repo: https://github.com/dflock/vitesse-jsonc-sort-keys-repro - this is a fork of vitesse, where I've run the following command (which you can see in the git log):
eslint succeeds. Then I ran this to install a module with a name starting with a number:
eslint succeeds. Then I ran this to run taze:
and I get this:
Reproduction
https://github.com/dflock/vitesse-jsonc-sort-keys-repro
System Info
Used Package Manager
pnpm
Validations
The text was updated successfully, but these errors were encountered: