Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: 'exechangeRate' should be 'exchangeRate' #101

Open
hwhsu1231 opened this issue Dec 1, 2024 · 1 comment
Open

Typo: 'exechangeRate' should be 'exchangeRate' #101

hwhsu1231 opened this issue Dec 1, 2024 · 1 comment

Comments

@hwhsu1231
Copy link

Additional context

I noticed a typo in a variable name within the project.

The variable exechangeRate/SPONSORKIT_AFDIAN_EXECHANGERATE/AFDIAN_EXECHANGERATE appear to be a misspelling of exchangeRate/SPONSORKIT_AFDIAN_EXCHANGERATE/AFDIAN_EXCHANGERATE, which represent "Exchange Rate".

exechangeRate: Number.parseFloat(process.env.SPONSORKIT_AFDIAN_EXECHANGERATE || process.env.AFDIAN_EXECHANGERATE || '0') || undefined,

Since this sponsorkit package is widely used, I opted not to submit a PR directly to avoid potentially disrupting downstream projects that depend on it. I leave it to the authors to decide whether to address this issue.

@sxzz
Copy link
Member

sxzz commented Dec 1, 2024

Let's fix it by introducing a new option and marking the old one as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants