Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long-running processes via nr breaking auto complete when cancelled #244

Open
3 tasks done
hirasso opened this issue Dec 19, 2024 · 1 comment
Open
3 tasks done
Labels
enhancement New feature or request

Comments

@hirasso
Copy link

hirasso commented Dec 19, 2024

Clear and concise description of the problem

When I run long-running processes via nr and cancel them via ctrl+c, my terminal's autocompletion stops working:

ni-nr-watch

Suggested solution

If achievable, it would be nice if nr <script-name> could exit processes as cleanly as pnpm <script-name>, where this problem doesn't appear:

ni-pnpm-watch

Alternative

Use pnpm <script-name> instead of nr <script-name>.

Additional context

Shell: [fish shell](https://fishshell.com/
OS: MacOS 14.1.1 Sonoma
Terminal: iTerm2

I hope that this is enough context. Bash also behaves funnily. For example, if I run nr <script-name and then cancel it, usually I would use the up key to re-run the previous command. Instead of providing the previous command to me, it prints this (comments from me):

52 assets
1089 modules
webpack 5.96.1 compiled successfully in 4827 ms # my test task
^C # SIGINT sent by me
bash-4.4$ ^[[A # that's me pressing the up-key
nr watch # when I press "enter", the script actually gets re-run. So this might have to do with the output to the terminal?

Validations

@hirasso hirasso added the enhancement New feature or request label Dec 19, 2024
@hirasso
Copy link
Author

hirasso commented Dec 19, 2024

I chose to create this issue as an enhancement request instead of a bug report as I don't know if what I'm looking for is even achievable with the architecture of ni.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant