Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent pathing dependant on neighbour_splitting #301

Open
hjabbot opened this issue Oct 8, 2024 · 2 comments
Open

Inconsistent pathing dependant on neighbour_splitting #301

hjabbot opened this issue Oct 8, 2024 · 2 comments

Comments

@hjabbot
Copy link
Collaborator

hjabbot commented Oct 8, 2024

Describe the bug
In doing some optimisation tests, I came across a case where the path varies wildly between a non-uniform mesh and a uniform mesh split to the max split level of the non-uniform. Further analysis showed that this pathing occurs when neighbour_splitting is turned on (the default) at the add_vehicle stage. I think that this is still a pathing issue; but a stark difference is shown between the neighbour_splitting on/off meshes, so something about the small cellboxes that are added has thrown off the pathing.

To Reproduce
Optimise routes with the configs provided. Outputs also provided to save the hassle.
issue.zip

Screenshots & Files
Non-Uniform, No Currents, No NeighbourSplitting
nu_nc_nns

Non-Uniform, With Currents, No NeighbourSplitting
nu_wc_nns

Non-Uniform, With Currents, With NeighbourSplitting
nu_wc_wns

Uniform, No Currents, With NeighbourSplitting
u_nc_wns

Uniform, With Currents, With NeighbourSplitting
u_wc_wns

@hjabbot
Copy link
Collaborator Author

hjabbot commented Oct 8, 2024

Some dijkstra paths, don't know why they would immediately diverge

Non-Uniform, With Currents, No NeighbourSplitting - Dijkstra
nu_wc_nns_dijkstra

Non-Uniform, With Currents, With NeighbourSplitting - Dijkstra
nu_ws_wns_dijkstra

@hjabbot
Copy link
Collaborator Author

hjabbot commented Oct 8, 2024

Found an issue with the dijkstra graph that I think is the root cause, attached an image showing the issue, as well as the configs and waypoints used to generate the routes (Note, these are slightly different waypoints than the original post). Looking at the dijkstra mesh outputs, looks like there is some small rounding errors that are causing the route to go into the rightmost cellbox. Also, the end waypoint does not match at the end of the dijkstra (no idea why it wouldn't?)

broken_dijkstra.zip
broken_dijkstra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant