Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing strategy outdated #260

Open
hjabbot opened this issue Mar 5, 2024 · 0 comments
Open

Testing strategy outdated #260

hjabbot opened this issue Mar 5, 2024 · 0 comments
Assignees
Labels
Documentation Documentation & Code Commeting Unit/Regression Test Adding in a new testing strategy either unit or regression

Comments

@hjabbot
Copy link
Collaborator

hjabbot commented Mar 5, 2024

The testing strategy is a bit confusing at the moment. We need to put a set of test files to run through for each file mentioned in them to avoid missing regression tests when putting in PRs.

e.g.
This table means that test_routes_dijkstra.py and test_routes_smoothed.py should both be run in the case that any of crossing.py, crossing_smoothing.py, or route_planner.py are altered, but instead it looks like no test should be run for route_planner.py being altered.

Route Planning

Files altered Tests
crossing.py tests/regression_tests/test_routes_dijkstra.py
crossing_smoothing.py tests/regression_tests/test_routes_smoothed.py
route_planner.py

Also just a personal opinion: I am constantly forgetting that testing_strategy.md in the tests folder rather than the .github folder when I'm looking up what tests to run. Anyone else have this issue? If so I suggest moving it to .github for consistency's sake.

@hjabbot hjabbot added the Documentation Documentation & Code Commeting label Mar 6, 2024
@Ulvetanna Ulvetanna added this to the 0.4 milestone Apr 10, 2024
@Ulvetanna Ulvetanna added the Unit/Regression Test Adding in a new testing strategy either unit or regression label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation & Code Commeting Unit/Regression Test Adding in a new testing strategy either unit or regression
Projects
None yet
Development

No branches or pull requests

2 participants