Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2点优化 #103

Open
crazyair opened this issue Dec 27, 2020 · 12 comments · May be fixed by #109
Open

2点优化 #103

crazyair opened this issue Dec 27, 2020 · 12 comments · May be fixed by #109

Comments

@crazyair
Copy link
Member

1·、

upgradeMessage('Form');
提示升级 error 能支持配置不提示吗
2、能添加 Picker 组件吗?

@crazyair
Copy link
Member Author

@shaodahong 帮忙看下

@shaodahong
Copy link
Member

提示升级 error 能支持配置不提示吗?

应该不行,这个包就是为了 3 -> 4 平滑升级用的

能添加 Picker 组件吗?

DatePicker ? 可以

@crazyair
Copy link
Member Author

crazyair commented Dec 28, 2020

提示升级 error 能支持配置不提示吗?

应该不行,这个包就是为了 3 -> 4 平滑升级用的

项目很大,兼容包估计得呆很久,自己知道是 v3 v4 混用,但是错误提示挺烦的,支持定义个变量配置成 false 就可以

@crazyair
Copy link
Member Author

crazyair commented Dec 28, 2020

DatePicker ? 可以

好的,添加完后我再测试升级项目看看还有什么错误。

@crazyair
Copy link
Member Author

添加 DatePicker 有什么注意的吗?你忙的话,我尝试添加下?

@shaodahong
Copy link
Member

DatePicker v3 和 v4 有什么 breaking 么

@crazyair
Copy link
Member Author

DatePicker v3 和 v4 有什么 breaking 么

第二条我就说了,然后删了评论,你看邮件历史。总之还是希望能加 DatePicker

@crazyair
Copy link
Member Author

crazyair commented Dec 29, 2020

你回复的 可以,我以为你要加了呢?怎么还问为什么加?

@shaodahong
Copy link
Member

shaodahong commented Dec 30, 2020

你回复的 可以,我以为你要加了呢?怎么还问为什么加?

删除了我没看到,可以是因为我看了v3 和 v4 的底层不一样,当然了我没用ts, 如果要改,组件没问题类型有问题的话应该改的是 codemod

@crazyair
Copy link
Member Author

恩,那 DatePicker 加吗

@shaodahong
Copy link
Member

等我节后回来加吧

@crazyair
Copy link
Member Author

在加了吗

@shaodahong shaodahong linked a pull request Jan 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants