Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color prop for custom IconFont component is incorrect #497

Open
JounQin opened this issue Aug 30, 2021 · 2 comments · May be fixed by #498
Open

color prop for custom IconFont component is incorrect #497

JounQin opened this issue Aug 30, 2021 · 2 comments · May be fixed by #498

Comments

@JounQin
Copy link

JounQin commented Aug 30, 2021

image

color should be on svg.
@JounQin
Copy link
Author

JounQin commented Aug 30, 2021

related ant-design/ant-design#13137 (comment)

@JounQin
Copy link
Author

JounQin commented Aug 30, 2021

Current workaround:

export function Icon({ color, style }: IconFontProps) {
  return (
    <IconFont
      style={{
        color,
        ...style,
      }}
      {...props}
    />
  )
}

JounQin added a commit to JounQin/ant-design-icons that referenced this issue Aug 30, 2021
@JounQin
fix: color should be svg property
7e6f7d4 
close ant-design#497
@JounQin JounQin linked a pull request Aug 30, 2021 that will close this issue
Open
JounQin added a commit to JounQin/ant-design-icons that referenced this issue Sep 17, 2024
@JounQin
fix: color should be svg property
054c4bf 
close ant-design#497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: color should be svg property JounQin/ant-design-icons
1 participant
@JounQin