Set KUBECONFIG to the $HOME/.kube/config if missing #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support root or non-root docker invocations, set the KUBECONFIG specifically to the passed .kube dir. The reason is that 'oc' incovation as root is by default looking for the .kube dir uner `/root/.kube/config` where as non-root is looking at $HOME/.kube/config. With this we always set KUBECONFIG, so root invocation of `oc` commands will always find the passed in config. Fixes: ansibleplaybookbundle#298 Signed-off-by: Roy Golan <[email protected]>
|
@dymurray please review |
dymurray
approved these changes
Jul 25, 2018
|
Looks good, thanks for submitting. |
djzager
approved these changes
Jul 25, 2018
rgolangh
commented
Jul 26, 2018
| @@ -16,6 +16,7 @@ if ! [[ -z "${DOCKER_CERT_PATH}" ]] && [[ ${DOCKER_CERT_PATH} = *"minishift"* ]] | |||
| fi | |||
|
|
|||
| KUBECONFIG_ENV="${KUBECONFIG:+-v ${KUBECONFIG}:${KUBECONFIG} -e KUBECONFIG=${KUBECONFIG}}" | |||
| [[ -z $KUBECONFIG ]] && KUBECONFIG_ENV="${KUBECONFIG:--v $HOME/.kube:/.kube -e KUBECONFIG=/.kube/config}" | |||
There was a problem hiding this comment.
Maybe even better, remove this, and just set KUBECONFIG in line 17, if its not set yet:
KUBECONFIG=${KUBECONFIG:-/.kube/config}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support root or non-root docker invocations, set the KUBECONFIG
specifically to the passed .kube dir. The reason is that 'oc' incovation
as root is by default looking for the .kube dir uner
/root/.kube/configwhere as non-root is looking at $HOME/.kube/config.With this we always set KUBECONFIG, so root invocation of
occommandswill always find the passed in config.
Fixes: #298