Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

incorrect caching: classified PR as new_module even though the module it modifies was merged earlier #1167

Open
felixfontein opened this issue Feb 12, 2019 · 2 comments
Open

incorrect caching: classified PR as new_module even though the module it modifies was merged earlier #1167

felixfontein opened this issue Feb 12, 2019 · 2 comments
Labels
bug

Comments

@felixfontein
Copy link
Contributor

I today merged a new module (ansible/ansible#50622), then rebased two PRs to current devel, and included modifications for these new modules as well. Afterwards, ansibot adds new_module and new_plugin labels to the PR.

Affected PRs: ansible/ansible#51939, ansible/ansible#51999
@gundalow gundalow added the bug label Mar 6, 2019
@felixfontein felixfontein mentioned this issue Apr 9, 2019
Merged
@felixfontein
Copy link
Contributor Author

Another case: ansible/ansible#56103, ansible/ansible#56186

@felixfontein
Copy link
Contributor Author

In this new case, the new PR adds another module and modifies the previously merged module, and gets the "this PR contains more than one new module" error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gundalow @felixfontein