Improve logic of find_children (#4161)

Author: ssbarnea

.github/workflows/tox.yml

@@ -72,7 +72,7 @@ jobs:
     env:
       # Number of expected test passes, safety measure for accidental skip of
       # tests. Update value if you add/remove tests.
-      PYTEST_REQPASS: 879
+      PYTEST_REQPASS: 882
     steps:
       - uses: actions/checkout@v4
         with:

examples/playbooks/common-include-1.yml

@@ -8,3 +8,5 @@
     - name: Some include_tasks with file and jinja2
       ansible.builtin.include_tasks:
         file: "{{ 'tasks/included-with-lint.yml' }}"
+    - name: Some include 3
+      ansible.builtin.include_tasks: file=tasks/included-with-lint.yml

examples/playbooks/common-include-wrong-syntax.yml

@@ -0,0 +1,9 @@
+---
+- name: Fixture for test coverage
+  hosts: localhost
+  gather_facts: false
+  tasks:
+    - name: Some include with invalid syntax
+      ansible.builtin.include_tasks: "file="
+    - name: Some include with invalid syntax
+      ansible.builtin.include_tasks: other=tasks/included-with-lint.yml

examples/playbooks/common-include-wrong-syntax2.yml

@@ -0,0 +1,8 @@
+---
+- name: Fixture for test coverage
+  hosts: localhost
+  gather_facts: false
+  tasks:
+    - name: Some include with invalid syntax
+      ansible.builtin.include_tasks:
+        file: null

examples/playbooks/common-include-wrong-syntax3.yml

@@ -0,0 +1,7 @@
+---
+- name: Fixture
+  hosts: localhost
+  tasks:
+    - name: Fixture
+      ansible.builtin.include_role:
+        name: include_wrong_syntax

examples/playbooks/include.yml

@@ -11,6 +11,7 @@
   tasks:
     - ansible.builtin.include_tasks: tasks/x.yml
     - ansible.builtin.include_tasks: tasks/x.yml y=z
+    - ansible.builtin.include_tasks: file=tasks/x.yml
 
   handlers:
     - ansible.builtin.include_tasks: handlers/y.yml

examples/roles/include_wrong_syntax/tasks/main.yml

@@ -0,0 +1,3 @@
+---
+- name: Invalid syntax for import (coverage)
+  ansible.builtin.import_tasks: wrong=imported_tasks.yml

examples/roles/var_naming_pattern/tasks/include_task_with_vars.yml

@@ -1,12 +1,15 @@
 ---
-- name: include_task_with_vars | Foo
+- name: include_task_with_vars | Var1
+  ansible.builtin.include_tasks: file=../tasks/included-task-with-vars.yml
+
+- name: include_task_with_vars | Var2
   ansible.builtin.include_tasks: ../tasks/included-task-with-vars.yml
   vars:
     var_naming_pattern_1: bar
     _var_naming_pattern_2: ... # we allow _ before the prefix
     __var_naming_pattern_3: ... # we allow __ before the prefix
 
-- name: include_task_with_vars | Foo
+- name: include_task_with_vars | Var3
   ansible.builtin.include_role:
     name: bobbins
   vars:

playbook.yml

@@ -1,6 +1,7 @@
 ---
 - name: Example
   hosts: localhost
+  gather_facts: false
   tasks:
     - name: include extra tasks
       ansible.builtin.include_tasks:

src/ansiblelint/rules/role_name.py

@@ -164,7 +164,7 @@ def _infer_role_name(meta: Path, default: str) -> str:
             if meta_data:
                 try:
                     return str(meta_data["galaxy_info"]["role_name"])
-                except KeyError:
+                except (KeyError, TypeError):
                     pass
         return default