Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #46 #47

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fixing issue #46 #47

merged 1 commit into from
Aug 27, 2024

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Aug 22, 2024

Overall Review of Changes:
Fixing issue #46 where post.yml is not executing

Issue Fixes:
#46

Enhancements:
Performs a windows reboot when needed.

How has this been tested?:
Locally, by running the role fork.

Signed-off-by: Mathieu Fortin <[email protected]>
@mfortin
Copy link
Contributor Author

mfortin commented Aug 27, 2024

@frederickw082922 @MrSteve81 Please review

@MrSteve81
Copy link
Contributor

Great catch! Will Have @frederickw082922 also look at it this morning.

MrSteve81

This comment was marked as duplicate.

Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@MrSteve81 MrSteve81 self-requested a review August 27, 2024 12:49
Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mfortin ! Thank you!

@MrSteve81 MrSteve81 merged commit c01da70 into ansible-lockdown:devel Aug 27, 2024
3 checks passed
@mfortin mfortin deleted the issue-46 branch September 6, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants