Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 #43

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Issue 38 #43

merged 5 commits into from
Apr 23, 2024

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Apr 23, 2024

Overall Review of Changes:
Updating controls as per expected results from CIS Benchmark

Issue Fixes:
#38

Enhancements:
None

How has this been tested?:
Tested by running role from this branch on a fresh instance

mfortin added 4 commits April 23, 2024 09:07
Signed-off-by: Mathieu Fortin <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
Signed-off-by: Mathieu Fortin <[email protected]>
@frederickw082922 frederickw082922 self-requested a review April 23, 2024 14:53
Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mfortin !! Nice work!!! I see you added a tag "- level1-corporate-enterprise-environment" to 18.6.4.3! It does not fit with this role! Kindly revert the tag! Everything else seems accurate! Appreciate the fixes!!

Signed-off-by: Mathieu Fortin <[email protected]>
Copy link
Contributor

@MrSteve81 MrSteve81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

@frederickw082922 frederickw082922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mfortin ! Approved!

@frederickw082922 frederickw082922 merged commit eb332ce into ansible-lockdown:devel Apr 23, 2024
3 checks passed
@mfortin mfortin deleted the issue-38-redo branch June 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants