Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 1.7.2 in branch benchmark_v2.0.0 has incorrect indentation #260

Open
kbknapp opened this issue Dec 3, 2024 · 2 comments
Open

Task 1.7.2 in branch benchmark_v2.0.0 has incorrect indentation #260

kbknapp opened this issue Dec 3, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@kbknapp
Copy link

kbknapp commented Dec 3, 2024

Describe the Issue

In #255 branch.

     - name: "1.7.2 | PATCH | Ensure GDM login banner is configured | banner settings"
       ansible.builtin.lineinfile:  # noqa: args[module]
         path: "/etc/dconf/db/{{ prelim_dconf_system_db }}.d/00-login-screen"
         regexp: "{{ item.regexp }}"
         line: "{{ item.line }}"
         insertafter: "{{ item.insertafter }}"
         create: true
         owner: root
         group: root
         mode: 'u-x,go-wx'
-        loop:
-          - { regexp: "\\[org\\/gnome\\/login-screen\\]", line: "[org/gnome/login-screen]", insertafter: EOF }
-          - { regexp: "banner-message-enable", line: "banner-message-enable=true", insertafter: "\\[org\\/gnome\\/login-screen\\]" }
-          - { regexp: "banner-message-text", line: "banner-message-text='{{ ubtu22cis_warning_banner | regex_replace('\n', ' ') | trim }}'", insertafter: "banner-message-enable" }
+      loop:
+        - { regexp: "\\[org\\/gnome\\/login-screen\\]", line: "[org/gnome/login-screen]", insertafter: EOF }
+        - { regexp: "banner-message-enable", line: "banner-message-enable=true", insertafter: "\\[org\\/gnome\\/login-screen\\]" }
+        - { regexp: "banner-message-text", line: "banner-message-text='{{ ubtu22cis_warning_banner | regex_replace('\n', ' ') | trim }}'", insertafter: "banner-message-enable" }
       notify: Update dconf

Actual Behavior

At present results in item is undefined

@kbknapp kbknapp added the bug Something isn't working label Dec 3, 2024
@uk-bolly uk-bolly assigned uk-bolly and unassigned uk-bolly Dec 4, 2024
uk-bolly added a commit that referenced this issue Dec 4, 2024
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly
Copy link
Member

uk-bolly commented Dec 4, 2024

hi @kbknapp

Thank you for the rapid feedback before PR merge. This has now been addressed and in the latest PR updated.

Many thanks once again

uk-bolly

@uk-bolly
Copy link
Member

hi @kbknapp

This should now be in a correct place, all linting has been updated to the latest configurations and hoping the PR will be approved today for merging into devel.

Thank you once again for your feedback.

uk-bolly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants