Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1r2 updates #53

Merged
merged 8 commits into from
Oct 8, 2024
Merged

V1r2 updates #53

merged 8 commits into from
Oct 8, 2024

Conversation

uk-bolly
Copy link
Member

@uk-bolly uk-bolly commented Oct 7, 2024

Overall Review of Changes:

Several typos resolved
improved variable quoting
improved regex
idempotence
reboot warning added

How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly requested a review from georgenalen October 7, 2024 14:13
Copy link

@georgenalen georgenalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Signed-off-by: Mark Bolwell <[email protected]>
@uk-bolly uk-bolly merged commit 409b654 into devel Oct 8, 2024
4 checks passed
@uk-bolly uk-bolly deleted the v1r2_updates branch October 29, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants