Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address #34 by making prelim task conditions "or" #35

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Coconutcoo
Copy link
Contributor

Overall Review of Changes:
Switch conditions for PRELIM | Find all sudoers files. and PRELIM | Find all pwquality files. to be an "or" not an "and", as none of the controls that use the variables these tasks register have explicit requirements on any other control that uses the variable.

Issue Fixes:
#34

Enhancements:
N/A

How has this been tested?:
pre-commit run passed, changes were also successfully applied to a machine. With rhel_09_432015 disabled, the "Find all sudoers files" task still ran, and the rest of the playbook completely successfully.

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch Thank you

@uk-bolly uk-bolly merged commit 8f7ef4e into ansible-lockdown:devel Sep 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants