Dynamically set rhel9stig_gui variable #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PrymalInstynct <[email protected]>
|
Great change and piece of work. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
I believe this role would be improved by dynamically determining if the target system to be locked down has Gnome Desktop installed or not. This makes management of the inventory easier and based on my analysis there is not a justification to set this variable statically.
This could be accomplished in a number of ways, I chose to stat the gnome-version.xml file that is installed when the Gnome Desktop packages are installed.
Issue Fixes:
N/A
Enhancements:
Quality of life improvement
How has this been tested?:
Built a fresh Rocky 9 VM with Gnome Desktop installed and executed the entire role.