-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically set rhel9stig_gui variable #24
Conversation
Signed-off-by: PrymalInstynct <[email protected]>
Signed-off-by: PrymalInstynct <[email protected]>
36cf760
to
7ed86f4
Compare
Signed-off-by: PrymalInstynct <[email protected]>
I am struggling to figure out why this PR is failing when run against a target without a GUI. For some reason From what I can tell the |
That is indeed, strange, i feel debug investigation taking place. I will look at this and get back to you. kindest uk-bolly |
Taking a quick look through this today. The defaults/main.yml is not getting a value you expect for your stat to set the value to true. Current settings gives the following debug
I have suggest change your PR slightly.
Seems to be what you are looking for and also skips the two controls in question. You would also need to GPG sign all your commits in order to pass as well. Hope that makes sense. kindest uk-bolly |
Signed-off-by: PrymalInstynct <[email protected]>
updates: - [github.com/ansible-community/ansible-lint: v24.6.1 → v24.7.0](ansible/ansible-lint@v24.6.1...v24.7.0)
Signed-off-by: PrymalInstynct <[email protected]>
Signed-off-by: PrymalInstynct <[email protected]>
Signed-off-by: PrymalInstynct <[email protected]>
Signed-off-by: PrymalInstynct <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: jhomen368 <[email protected]>
Fubar'd the rebase to GPG sign the commits in the PR so I am closing this one and creating a new one. |
Overall Review of Changes:
I believe this role would be improved by dynamically determining if the target system to be locked down has Gnome Desktop installed or not. This makes management of the inventory easier and based on my analysis there is not a justification to set this variable statically.
This could be accomplished in a number of ways, I chose to stat the gnome-version.xml file that is installed when the Gnome Desktop packages are installed.
Issue Fixes:
N/A
Enhancements:
Quality of life improvement
How has this been tested?:
Built a fresh Rocky 9 VM with Gnome Desktop installed and executed the entire role.