Simplify package installation process #74
Conversation
Currently, `warn` is passed to `args` argument in a few places. `warn` was removed in ansible 2.14[1] which makes it impossible to use ara_api role with ansible >=2.14. Patch proposes an easier way to install required packages on all package managers and ensure that their cache is updated. [1] ansible/ansible#70504
|
Build failed. ❌ ara-role-api-distributed-sqlite FAILURE in 11m 07s |
|
Hi @damiandabrowski5 and thanks for the PR! We're in the middle of refreshing the collection as it ran out of maintenance so it will be a good idea to include something like this as well. My priority is to land #71 first which will get the CI back in shape and we will eventually circle back to this. Thanks for your patience in the meantime. |
| set_fact: | ||
| ara_api_missing_packages: "{{ ara_api_required_packages | difference(ansible_facts['packages'].keys()) }}" | ||
|
|
||
| # Only attempt to elevate privileges if there are any missing packages |
There was a problem hiding this comment.
I'd rather not remove the logic around detecting whether or not packages are already installed and the reason why is in that comment.
In other words, the role is designed to be executable under an unprivileged user if the necessary packages have already been installed: ara can be set up and run within a user's home directory without relying on root or sudo privileges.
By removing this logic, ansible will try to elevate privileges (become: true) and it will not work if Ansible isn't running with root or sudo.
We can remove warn: false if it is an issue, which leaves the fix looking like this instead: Thulium-Drake@91ae432 (thanks @Thulium-Drake).
|
Hi @damiandabrowski5, sorry for the delay. I hope my explanation makes sense. We can either update this PR or submit a new one. Let us know if you would like to do it or we can take care of it. Thanks. |
|
@dmsimard thanks for an update, feel free to either update my PR or abandon it and create new one ;) I'm fine with both solutions |
Currently,
warnis passed toargsargument in a few places.warnwas removed in ansible 2.14[1] which makes it impossible to use ara_api role with ansible >=2.14.Patch proposes an easier way to install required packages on all package managers and ensure that their cache is updated.
[1] ansible/ansible#70504