Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm "post_renderer" does not work on 2.4.* #679

Open
davidfrickert opened this issue Feb 21, 2024 · 2 comments
Open

Helm "post_renderer" does not work on 2.4.* #679

davidfrickert opened this issue Feb 21, 2024 · 2 comments
Labels
topic/helm Issues relating to helm plugins type/bug Something isn't working

Comments

@davidfrickert
Copy link

SUMMARY

When attempting to use post_renderer on kubernetes.core.helm, the result command is bogus and does not work:

 msg: '[Errno 2] No such file or directory: b''--post-renderer=/tmp/ansible.1zs3ebirpg-db-kustomize/kustomize.sh'': b''--post-renderer=/tmp/ansible.1zs3ebirpg-db-kustomize/kustomize.sh'''

The command seems to be overwritten when using post_renderer: https://github.com/ansible-collections/kubernetes.core/blob/2.4.1/plugins/modules/helm.py#L525
On 3.0.0, it seems that this might have been fixed but did not test yet. At least the code does not seem to overwrite the command and it is being done on 2.4.1. https://github.com/ansible-collections/kubernetes.core/blob/3.0.0/plugins/modules/helm.py#L564

Backport to 2.4.*?

ISSUE TYPE
  • Bug Report
COMPONENT NAME

kubernetes.core.helm

COLLECTION VERSION

2.4.1

STEPS TO REPRODUCE

Try to install any helm chart with post_renderer option.

EXPECTED RESULTS

post_renderer works.

ACTUAL RESULTS

usage of post_renderer makes it that helm is not actually invoked.

@gravesm gravesm added type/bug Something isn't working topic/helm Issues relating to helm plugins labels Feb 28, 2024
@uqix
Copy link

uqix commented May 8, 2024

I tested post_renderer on 2.4.0 and 3.0.1, it seems that it's totally ignored without error even for non-existent exe path.

@tldev-de
Copy link

had the same issue today. it doesn't work with 2.4.2, but does work with 3.0.0 and above. @davidfrickert thanks for this issue - it probably saved me hours of debugging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/helm Issues relating to helm plugins type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants