-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxmox_snap bug in timeout handling #9260
Comments
Files identified in the description: If these files are incorrect, please update the |
I fixed the logic error, but the fail_msg in this module need some more work imo. the messages currently include raw data like this:
|
Hi @h3po , thanks for reporting and, as it seems, fixing the problem. Could you please submit a Pull Request with the change? Thanks in advance! |
Summary
The code path supposed to return fail_json when the snapshot task runs into a timeout is not reached, resulting in "New-style module did not handle its own exit"
Issue Type
Bug Report
Component Name
proxmox_snap
Ansible Version
Community.general Version
Configuration
No response
OS / Environment
No response
Steps to Reproduce
it is impossible for
timeout == 0
to be true in thewhile timeout
loopExpected Results
The module should return the fail_json with message "Reached timeout" instead of "New-style module did not handle its own exit"
Actual Results
Code of Conduct
The text was updated successfully, but these errors were encountered: