Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with ejs template #297

Open
designfrontier opened this issue Oct 25, 2016 · 5 comments
Open

Experiment with ejs template #297

designfrontier opened this issue Oct 25, 2016 · 5 comments

Comments

@designfrontier
Copy link
Member

designfrontier commented Oct 25, 2016

Using the config object changes and the render changes from #292 #291 run a site using ejs and see if there are things that need to be changed.

Also look at whether autodetection of the engine and if there are defaults that make sense if we can autodetect

Part of this ticket should be creating documentation around using ejs and adding examples for how to use ejs with monument

@ExC0d3
Copy link

ExC0d3 commented Nov 25, 2016

Hi,
I would like to try and work out this issue. Since I'm a first time contributor is there anything that I should keep in mind while handling this?
As of now this is my understanding of the problem -

  • Add a template object in the global config object to provide configuration for templating engine which by default is going to be dotJs (Eg. ejs/jade)
  • Check if each render engine functions properly

Sorry if this approach seems a bit over simplified.

@designfrontier
Copy link
Member Author

Yeah that approach sounds pretty good. I have a branch up where I am working on getting the render items pulled into the config that you pass into the server. I am 90% of the way there (#301) just have some failing tests to get squared away. But looking through that may give you some more insight.

I am hoping to find sometime this weekend to get that change finished up and merged into the next release branch.

You can probably start working with that branch as your base.

@designfrontier
Copy link
Member Author

@designfrontier
Copy link
Member Author

also the config object would include the template engine itself, so the ejs engine as well as any config that it needs.

@designfrontier
Copy link
Member Author

designfrontier commented Dec 1, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants