refactor(config): simplify loading and fallbacks - #43932
Closed
kitlangton wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Consolidated into #43930 so the Plugin and configuration boundary cleanup can be reviewed together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Centralize well-known manifest loading and make Config's object narrowing explicit. Constant filesystem fallbacks now use Effect's dedicated
orElseSucceedcombinator without changing which failures are recovered.How
WellKnown.loadEntryworkflow across load, refresh, and add.isRecord.Effect.catchfallbacks in skill discovery withEffect.orElseSucceed.Scope
Behavior-preserving loading cleanup only; no config format, diagnostics, manifest, watch, or recovery-policy changes.
Testing
bun typecheckfrompackages/corebun turbo typecheck --concurrency=3(40-package workspace)