fix: keep tool child stdin closed and run tool commands non-interactively - #42854
Open
utk-code wants to merge 3 commits into
Open
fix: keep tool child stdin closed and run tool commands non-interactively#42854utk-code wants to merge 3 commits into
utk-code wants to merge 3 commits into
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
utk-code
force-pushed
the
fix-tool-interactive-stdin
branch
from
August 16, 2026 06:33
c7f218a to
0399535
Compare
Review of the non-interactive tool execution fix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #42773
Type of change
What does this PR do?
On Windows, tool commands that prompt on stdin (e.g.
npm execasking "Ok to proceed? (y)") hang — the prompt shows but nothing typed reaches the process, because the child stdin is an open pipe nothing closes and the TUI owns the console input.Changes:
CI=1,npm_config_yes=true,GIT_TERMINAL_PROMPT=0,NONINTERACTIVE=1, so tools like npm skip interactive prompts.How did you verify your code works?
Reproduced on Windows:
npm execwith an open stdin pipe hangs; withCI=1ornpm_config_yes=trueit completes. Checked no tests rely on the old default.Screenshots / recordings
N/A (not a UI change)
Checklist