[fix] Export pkg-config flags for cuda and hwloc - [merged]

[iskra-anl]

In GitLab by @NicolasDenoyelle on Oct 20, 2020, 12:02

Merges pkg_config_flags -> staging

pkg-config --libs aml and pkg-config --cflags aml now gives the correct set of flags.

Fix #74

[iskra-anl]

In GitLab by @NicolasDenoyelle on Oct 20, 2020, 12:05

@perarnau please check this MR.

I tested with options --with-cuda and --with-cuda=no. It is working and flags look ok to me.

Note that it would be nice to setup a CI stage where we try to build a dummy app linked with aml.

[iskra-anl]

In GitLab by @perarnau on Oct 20, 2020, 12:18

Commented on configure.ac line 169

Already done a few lines below ?

[iskra-anl]

In GitLab by @perarnau on Oct 20, 2020, 12:39

Note that it would be nice to setup a CI stage where we try to build a dummy app linked with aml.

I agree, installcheck is very tricky to figure out in general, but maybe we can find a way to leverage the nix environment for that.

[iskra-anl]

In GitLab by @perarnau on Oct 20, 2020, 12:39

changed the description

[iskra-anl]

In GitLab by @NicolasDenoyelle on Oct 20, 2020, 14:47

Commented on configure.ac line 169

changed this line in version 2 of the diff

[iskra-anl]

In GitLab by @NicolasDenoyelle on Oct 20, 2020, 14:48

added 1 commit

• 500dcec - [fix] Export pkg-config flags for cuda and hwloc

Compare with previous version

[iskra-anl]

In GitLab by @NicolasDenoyelle on Oct 20, 2020, 14:48

@perarnau ready when the pipeline goes through.

[iskra-anl]

In GitLab by @perarnau on Oct 20, 2020, 14:55

resolved all threads

[iskra-anl]

In GitLab by @perarnau on Oct 20, 2020, 14:55

merged

[iskra-anl]

In GitLab by @perarnau on Oct 20, 2020, 14:55

mentioned in commit 2910ba2