-
Notifications
You must be signed in to change notification settings - Fork 4
Bug: Modified create_organization function #1079
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise LGTM! @decon-harsh please do the following changes:
1.update the issue description with a GIF showing the fix
2. Fix the flake8 error. you can take reference from here to here.
On it! |
Will add a gif |
Added necessary gif and pics. Would like to show a new error.While Signing up as a volunteer , the city , country and state field has neither dropdowns nor their value gets saved the last screenshot clearly states the blank fields. I have opened one issue regarding the dropdown but it has not been yet reviewed. If you say I will love to work on both these issues. Ps: Sorry I am bad with giving names to databases and enteries :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise LGTM 👍
@decon-harsh please squash the commits.
a4e2a51
to
22a4290
Compare
Flake 8 error corrected
b70cd09
to
bb2746d
Compare
Check this @Kajol-Kumari |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Regarding this, Have you migrate the cities light? |
Yes, Please check and confirm here. Thanks |
@satya7289 the issue got solved , when i recreated the database and again made migrations! |
Modified create_organization function to handle Integrity Error which happens when user enters unlisted non unique organization.
Fixes #1042
Type of Change:
Mocks
Screenshot of Error
After the changes
Volunteer account gets created!
Registration with Unlisted Organisation "New Organization"
"New Organization" Exist in database
Registration with Listed Organisation (not approved)
Login
Code/Quality Assurance Only
How Has This Been Tested?
Manually tested
Instructions to reproduce
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only