-
Notifications
You must be signed in to change notification settings - Fork 4
Add task using Celery to send email verification for reset password #1030
Comments
@keshakaneria That is intentional because that's how Django's ConsoleHandler works, if the right SMTP credentials are passed in, then it would use SMTP to send the email. As for using celery, I don't find a strong reason as to why should we send one simple email using Celery. Feel free to prove me wrong. |
@SanketDG I wanted to use an 'Asynchronous task' where the mail will be sent in background and in the interface the according message will be displayed. Not using it will make the website keep loading until the mail through SMTP would send and then return the next step. |
Sorry, by mistake I closed the issue. Its opened again. |
That's fair, although sending one email would be mostly trivial, I am just not sure whether a highly cohesive dependency like Celery is worth it or not, most of the applications I have seen are for a large number of asynchronous tasks, that's where it really shines. This is definitely a valid issue though, let's see what other mentors think about this! |
Sure, thank you so much for letting me brainstorm again on this issue. |
@keshakaneria We can use cronjob. |
OSH, Can I work on it. |
@keshakaneria, can I use this Password Reset View, to reset the password without celery, as I don't have any experience using celery. |
@saideepesh000 Yes you can, unless and until it covers the main goal of the issue to send a mail and also displaying it in console to verify and reset the password successfully. |
@keshakaneria, Actually reset password section is already present on the website. and it's working. |
@saideepesh000 you dont have to include the code of its working. As you said the flow is absolutely perfect. What the aim of this issue to get the verification email on the mail id which is entered. Currently it is displayed in console, so in addition we need to get the mail in the id itself. |
@keshakaneria, Please once take a look at this, |
You edited and added your code to send the verification mail right? Seems perfect to me. Great job 👍 |
@keshakaneria, I just actually added only a few lines i.e to configure SMTP mail. Should I send a PR, so that you could understand it more? |
Yes @saideepesh000 you can. |
@saideepesh000 Any updates on PR? |
Actually I am busy with the placements going on, it'll be done in a day or two. |
You can report me the updates done by you, else I will have to unassign you, since it has been 10 days this issue is assigned to you. |
Sorry for the inconvenience, I may not be working for a while, till then assign this issue to someone else, I'd joining you, after all my things got finished (professional and personal). |
Okay thank you. Is anyone else ready to work on this issue? |
Hey @keshakaneria , I've worked with reset passwords in Django but with with celery.. |
You can try your hand on this isue then. Go for it. |
Hey @keshakaneria , I wanted to say not with celery..😅 |
So in the work you've previously learn is reset password as you said. Do that fulfill our requirements of sending the mail to the id? Currently it is getting displayed in console so along with this, we need to send it to the mail too. You can read the mentioned issue I have tagged here in above comments, you will get an idea. |
Actually we will just need the emailid and password of the gmail id from which we want to send email and then by doing some changes in settings.py we can easily send the email for password reset.. Then email will be sent to user's id which will have the link to change password.. |
That is also fine. I am saying that you do the changes according to the requirements and open a PR, then let me know the output of sending the mail to their inbox. |
@keshakaneria If this issue is open for reassignment, please assign it to me |
@keshakaneria can i try working on this? |
@Aaishpra Sure go for it. |
@keshakaneria just wanted to know if this issue has to be solved using celery only? |
Yes @Aaishpra |
Thanks for clarifying 😄 |
@keshakaneria Update: i am half way through the solution of this issue. But, since my mid semester exams are scheduled in a week so would be busy with them. Therefore i think i would require a bit more time to solve this and make the PR. Hope, you consider this. |
@Aaishpra I hope you are good to go now :) |
Aah, sorry for no updates@keshakaneria i am done with my exams and will update you with the PR soon😅 |
@keshakaneria well I tried lots of different approaches for solving this issue with celery (or even SMTP) but couldn't get the desired results. So, I am unassigning from this as I have already wasted a lot of your time, please make it available for others. Apologies again. |
Ahh.. no worries! That is fine. I hope you've learnt alot while researching to work things out! Others issues are open you for you :) |
Ya sure😊 i really learnt a lot. |
Description
In order to login into the system using forgot password, I need to verify my email address to get logged in to change the old password with the new one. Currently, the email is displayed in the console itself.
Acceptance Criteria
Update [Required]
Celery is an asynchronous task scheduler which helps to run different process in background which can be used here in order to create tasks for mailing system.
Definition of Done
Estimation
3 hours
The text was updated successfully, but these errors were encountered: