Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update author controller to return object on post #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FarzamMohammadi
Copy link

@FarzamMohammadi FarzamMohammadi commented Jul 17, 2022

Description

Author POST API, which originally returned a "Author added successfully created" message has been updated to return the created author object instead.

Fixes # [123]

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • Any dependent changes have been merged

Code/Quality Assurance Only

  • My changes generate no new warnings
  • Any dependent changes have been published in downstream modules

@welcome
Copy link

welcome bot commented Jul 17, 2022

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contributing Guidelines.🙌.We will get back to you as soon as we can.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

@FarzamMohammadi FarzamMohammadi force-pushed the Bug/return-created-author-object branch from 8babf2e to 2fc7978 Compare July 18, 2022 21:22
@FarzamMohammadi
Copy link
Author

Anyone wants to merge this? 😢

@NenadPantelic
Copy link
Contributor

@FarzamMohammadi can you please check these two comments I have left recently? Also, check how the frontend processes this response (I haven't opened it in a while, so I'm not sure whether we have this endpoint covered there 😅 ).

@FarzamMohammadi
Copy link
Author

@FarzamMohammadi can you please check these two comments I have left recently? Also, check how the frontend processes this response (I haven't opened it in a while, so I'm not sure whether we have this endpoint covered there 😅 ).

What comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants