Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to follow PEP8 guidelines #144

Open
devkapilbansal opened this issue Mar 25, 2021 · 13 comments
Open

Add tests to follow PEP8 guidelines #144

devkapilbansal opened this issue Mar 25, 2021 · 13 comments
Assignees
Labels
Category: Outreach/Research Changes or improvements related to external research of the app. Open Source Hack

Comments

@devkapilbansal
Copy link
Member

Is your feature request related to a problem? Please describe.

PEP stands for Python Enhancement Proposal. It is a style document that documents some best practices

Describe the solution you'd like

Code written in Python should follow standard practices and PEP8 guidelines. For this a linter that follows these guidelines or some sort of checks can be implemented

Describe alternatives you've considered

I would suggest using Flake8 to test if PEP8 best practices are followed in the code written or not. Additionally, Flake8 workflow tests can be setup to ensure pull requests made follow these guidelines as well.

Additional context

Flake8 is not the only tool available and other alternatives can be considered.

@welcome
Copy link

welcome bot commented Mar 25, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉for opening your very first issue in this project. AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸 Please adhere to our Code of Conduct.🙌 You may submit a PR if you like! If you want to report a bug🐞 please follow our Issue Template. Also make sure you include steps to reproduce it and be patient while we get back to you.😄

Feel free to join us on AnitaB.org Open Source Zulip Community.💖 We have different streams for each active repository for discussions.✨ Hope you have a great time there!😄

@devkapilbansal devkapilbansal added Category: Outreach/Research Changes or improvements related to external research of the app. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Mar 25, 2021
@devkapilbansal
Copy link
Member Author

Similar to anitab-org/bridge-in-tech-backend#226

@Aryamanz29
Copy link

I would like to work on this issue, Could you please assign it to me @devkapilbansal

@devkapilbansal
Copy link
Member Author

Hi @Aryamanz29 did you complete the necessary setup task??

@devkapilbansal
Copy link
Member Author

If yes,send some screenshots to the issue itself

@Anmollenka
Copy link

I would like to work on this.

@epicadk
Copy link
Member

epicadk commented Jun 7, 2021

@Anmollenka would you still like to work on this?

@Anmollenka
Copy link

Yes @epicadk

@epicadk epicadk removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jun 7, 2021
@devkapilbansal
Copy link
Member Author

Any update @Anmollenka

@Anmollenka Anmollenka removed their assignment Jul 28, 2021
@pypas
Copy link

pypas commented Jul 6, 2022

Hi @devkapilbansal, can I take this one?

@devkapilbansal
Copy link
Member Author

Sure @pypas assigning you

@pypas
Copy link

pypas commented Jul 8, 2022

Thanks @devkapilbansal! I've opened a PR, could you take a look when you have the time?

@devkapilbansal
Copy link
Member Author

Hi @pypas Can you please reachout to someone on Zulip channel instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Outreach/Research Changes or improvements related to external research of the app. Open Source Hack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants