Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Register form not completely visible #30

Open
Rahulm2310 opened this issue Feb 13, 2021 · 13 comments
Open

Bug: Register form not completely visible #30

Rahulm2310 opened this issue Feb 13, 2021 · 13 comments
Labels
Category: User Interface Improvements or additions to design. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes.

Comments

@Rahulm2310
Copy link
Contributor

Rahulm2310 commented Feb 13, 2021

Describe the bug

The register UI is not completely visible on laptop screen size and not scrollable. Also, the alerts are not completely visible and just shows up for merely 1 second.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://anitab-org.github.io/stem-diverse-tv-cms/
  2. Click on 'register'
  3. See error

Expected behavior

The page should be scrollable and alerts should remain for more time like 2-3 seconds or more.

Screenshots

register-ui-issue

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser : Chrome
  • Version: 84
@Rahulm2310
Copy link
Contributor Author

@annabauza Can you please confirm/approve this issue. This can be a good first timer issue.

@chinmaym07
Copy link
Member

chinmaym07 commented Feb 13, 2021

@Rahulm2310 have you tested these locally .?
Also the error that displays for a second that's not a error that's a confirmation that password matched & It should go like that , it occurs on the hosted because we are not getting back the correct response from the backend. Try this locally you will get it .
The errors are shown in red & confirmation is shown in blue .

Peek 2021-02-13 14-36
Register UI is completely visible .Can you please exactly point where the error is.?
Also thanks for testing this 👍🏻 😀
Locally it works like this
Peek 2021-02-09 20-41

@Rahulm2310
Copy link
Contributor Author

@chinmaym07 On my 14-inches screen, I face the issue and have added the GIF for the same. May be you possess a larger display.

Also the error that displays for a second that's not a error that's a confirmation that password matched

I mentioned alert and not error. I think the message even if a confirmation should stay at least for 2 seconds. Otherwise there is no point displaying them.

@chinmaym07
Copy link
Member

@Rahulm2310 It just a sign of notifying the user that he had entered correct credentials & in last GIF that I posted it stays there for more than 2-3 seconds & the GIF you posted above looks blurred to me sorry I am unable to find where the issue is with displaying of Registeration form.
Please check it once more , If you still face this issue of bad visibility of Registeration form.

@annabauza
Copy link
Contributor

approved. I don't think it's first timer issue.

@annabauza annabauza added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes. labels Feb 20, 2021
@jalajcodes
Copy link
Member

@annabauza Can I work on it?

@annabauza annabauza removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Mar 10, 2021
@annabauza
Copy link
Contributor

@jalajcodes yours

@jalajcodes
Copy link
Member

jalajcodes commented Mar 13, 2021

@Rahulm2310 Does @chinmaym07 reply resolves your problem about error not staying long enough?

In your case, the error stays for just a fraction because the request never gets sent to the correct url. This should be fixed soon.

@jalajcodes
Copy link
Member

I think its not necessary to show a confirmation when passwords match... instead, it should check if they don't match and then show the error and return from the function so the request doesn't get sent.

@Rahulm2310
Copy link
Contributor Author

@jalajcodes Are you working on this. If not started, you can make it available for OSH.

@jalajcodes
Copy link
Member

jalajcodes commented Mar 22, 2021

@Rahulm2310 yeah that's what I want to do, just waiting to get access to label issues in this repo😉

@Rahulm2310 Rahulm2310 added Category: User Interface Improvements or additions to design. Status: Available Issue was approved and available to claim or abandoned for over 3 days. and removed Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Mar 24, 2021
@Rahulm2310
Copy link
Contributor Author

@jalajcodes unassigning you and opening this for OSH aspirants 😉

@nlok5923
Copy link
Contributor

@Rahulm2310 can i take up this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: User Interface Improvements or additions to design. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

No branches or pull requests

6 participants