Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Remove rest_framework from package dependencies #586

Open
SanketDG opened this issue Jul 11, 2020 · 3 comments
Open

Remove rest_framework from package dependencies #586

SanketDG opened this issue Jul 11, 2020 · 3 comments
Labels
Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance.

Comments

@SanketDG
Copy link
Contributor

SanketDG commented Jul 11, 2020 •
edited
Loading

Description

As part of #565, I was auditing the requirements and found out that DRF was used!

DRF is probably the largest API framework out there for Django, and we don't even have an API!

Diving into the code, it seems like meetups/views.py ApiForVmsView just uses one single class APIView, which just sends out JSON data based on some request params. Nothing some good ol' Django can't do! There's no point of using such a large package to implement something so trivial.

Removing this should be fairly easy.

The second thing to look for how it's used in VMS, and whether we need it at all.

Estimation

12 hours

I'd be interested in mentoring someone formally since this is relatively easy. Please ping me on Zulip if you are relatively new here and you want to get started with your first PR!
@SanketDG SanketDG added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance. labels Jul 11, 2020
@sakshi1499
Copy link

@anitab-org/coding-team Anybody who wants to work on it?

@theyashshahs
Copy link
Contributor

@morrme go for it 👍

@theyashshahs theyashshahs removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 21, 2020
@theyashshahs
Copy link
Contributor

we have a zulip channel, where you can discuss anything related to portal

@morrme morrme removed their assignment Jul 21, 2020
@SanketDG SanketDG added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 27, 2020
@SanketDG SanketDG mentioned this issue Aug 5, 2020
Closed
@SanketDG SanketDG mentioned this issue Sep 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Maintenance Repository maintenance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SanketDG @morrme @sakshi1499 @theyashshahs