Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

Links on Homepage redirects to 400 Bad Request page #467

Open
3 tasks
isabelcosta opened this issue Dec 14, 2019 · 16 comments
Open
3 tasks

Links on Homepage redirects to 400 Bad Request page #467

isabelcosta opened this issue Dec 14, 2019 · 16 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days.

Comments

@isabelcosta
Copy link
Member

Description

As a user,
I need the links on the homepage to be correct,
so that I can learn more about AnitaB.org communities.

When clicking some buttons on the homepage, I get redirected to 400 Bad Request, because old website - http://anitaborg.org/ - does not redirect to the current AnitaB official website - https://anitab.org/.

E.g.: http://anitaborg.org/get-involved/systers/systers-initiatives/ should be http://anitab.org/get-involved/systers/systers-initiatives/ (which actually like this, redirects to https://anitab.org/systers/systers-initiatives/)

I think the file that handles this is /develop/systers_portal/templates/common/index.html.

Mocks

What I get right now:
image

Acceptance Criteria

Update [Required]

  • Make all links on homepage redirect to a valid page instead of 400 Bad Request

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 hour

@isabelcosta isabelcosta added Difficulty: EASY Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Dec 14, 2019
@joejones89
Copy link

I'm not sure if I did this correctly or not, but I tried to propose changes on the file. I told me that the files were the same?

I clicked edit on your file, copied it to notepad++, made changes, pasted it back in and clicked propose changes after writing notes.

@isabelcosta
Copy link
Member Author

Did you create a Pull Request as a result of your proposed changes? Did you do this on your fork or on this repository? @cervantez07 Can you link here the changes you did?

What you would do here would be:

  1. forking the project
  2. change on your forked repository cervantez07/portal , the file you would have to change
  3. submit the Pull Request

But before submitting the pull request, it would be could to run the code and test it out locally to see if the change you done was on the right file, and was reflected on the homepage.

How does this sound @cervantez07 ?

@sp00p sp00p mentioned this issue Dec 15, 2019
5 tasks
@pianeta051
Copy link

Hi Isabel,

Would you like me to help you with this?.
Is anyone working on this?

@sayashraaj
Copy link

Can I work on this please? This is my domain of interest and I would love to work on this

@isabelcosta
Copy link
Member Author

@pianeta051 @sayashraaj you're welcome to contribute to this project :) Although I'm not a maintainer for this specific project so I won't be able to merge and such.

@arunikayadav42
Copy link
Contributor

Hi! I am a newbie to open source and pretty well-versed with python and django. Can I contribute to this issue :). Also which slack/irc channels should I join for updates?

@ritwickraj78
Copy link
Contributor

@isabelcosta May I take up this issue?

@arunikayadav42
Copy link
Contributor

@isabelcosta May I take up this issue?

Already working on it :)

@arunikayadav42
Copy link
Contributor

@isabelcosta May I take up this issue?

Awaiting the maintainers to assign it to me. Please take up some other issue. Thanks :)

@arunikayadav42
Copy link
Contributor

@isabelcosta Please assign the issue to me. Thanks

@isabelcosta
Copy link
Member Author

Ok so now I can help more here with this issue. I was focused on maintaining mentorship-backend and mentorship-android, now I help more here. Going of first come and first serve. Since there are no updates from @cervantez07 , @pianeta051 do you want to work on this issue? Feel free to send a PR for it if that's the case, or let me know you will not work on this, so I can assign this to someone else.

If we don't get a response in the next days I can assign this to you @sayashraaj if you still want to work on this, and then @arunikayadav42 (following the same logic). I'll create more issues for first-timers-only, so you can find more of these later :)

sayashraaj added a commit to sayashraaj/portal that referenced this issue Mar 8, 2020
Updated "anitaborg.org" to "anitab.org" on all links so it does not redirect to 400Bad Request Page
@sayashraaj
Copy link

Done, I have updated the links.
Updated "anitaborg.org" to "anitab.org" on all links so it does not redirect to 400 Bad Request Page

@isabelcosta
Copy link
Member Author

@sayashraaj can you link this issue on your PR? Have you submitted one PR?

sayashraaj added a commit to sayashraaj/portal that referenced this issue Mar 15, 2020
@sayashraaj
Copy link

I have submitted a PR referencing this issue. I always fulfil my commitments as contributing to Open Source is what I genuinely like doing
The PR is referenced by #498

sayashraaj added a commit to sayashraaj/portal that referenced this issue Mar 27, 2020
sayashraaj added a commit to sayashraaj/portal that referenced this issue Mar 27, 2020
This was referenced Apr 11, 2020
@sammy1997 sammy1997 added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 14, 2020
@mayburgos mayburgos added First Timers Only Good for newcomers. and removed First-Timers-Only labels May 9, 2020
@adwait2001
Copy link

is it available

@Aaishpra
Copy link
Member

Aaishpra commented Sep 26, 2020

@isabelcosta @mayburgos can i work on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. First Timers Only Good for newcomers. Status: Available Issue was approved and available to claim or abandoned for over 3 days.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants