Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

bug: Find Members button not navigating properly #113

Open
techno-disaster opened this issue Jul 20, 2020 · 17 comments · May be fixed by #119
Open

bug: Find Members button not navigating properly #113

techno-disaster opened this issue Jul 20, 2020 · 17 comments · May be fixed by #119
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Bug Bug or Bug fixes.

Comments

@techno-disaster
Copy link
Contributor

Describe the bug
When the user is not in a relation we show a find members button on the relation page, but this is not working as intended, the button does not navigate in the bottom navy bar.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Relation page', if you are not in a relation you will see a find members button, incase you are just use this account qwerty12:12345678 once you tap on the find members button you will be able to see the members page for the first time but the bottom navy bar will still say Relation page
@techno-disaster techno-disaster added Type: Bug Bug or Bug fixes. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. labels Jul 20, 2020
@techno-disaster
Copy link
Contributor Author

@bharat-1809 would you like to work on this? or anyone else from @anitab-org/coding-team ?

@HaripriyaB
Copy link
Contributor

Can I take this up?

@Akanksha1212
Copy link
Contributor

Sure @HaripriyaB

@Akanksha1212 Akanksha1212 removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 21, 2020
@techno-disaster
Copy link
Contributor Author

@HaripriyaB whats the status of the issue?

@HaripriyaB
Copy link
Contributor

Working on it. But I'm stuck at how to navigate from one tab to another with the button click. I tried to navigate but it threw error.

@Akanksha1212
Copy link
Contributor

Hi, @HaripriyaB Were you able to resolve the error? If not can you share the details about the error here

@HaripriyaB
Copy link
Contributor

When I add navigator in onpressed of find members button it shows error.

@techno-disaster
Copy link
Contributor Author

techno-disaster commented Jul 27, 2020

Yep, you will have to change the whole navigation for bottom navy bar probably. Use bloc like we did before. Check how tabs were navigated before #108 commit. @HaripriyaB Once you get this it will be super easy

@techno-disaster
Copy link
Contributor Author

@HaripriyaB if you are still stuck with this, I can take over this issue?

@HaripriyaB
Copy link
Contributor

yeah ..I guess I'm not able to figure out the solution.I tried all possible ways. So you take it up.

@HaripriyaB HaripriyaB removed their assignment Jul 29, 2020
@bharat-1809
Copy link
Contributor

@HaripriyaB and @techno-disaster Can I take up this?

@techno-disaster
Copy link
Contributor Author

Hey @bharat-1809 i already fixed this and will be sending an PR tonight can you take up one of the other issues?

@techno-disaster techno-disaster self-assigned this Jul 29, 2020
@bharat-1809
Copy link
Contributor

@techno-disaster Yeah, Sure :)

@isabelcosta
Copy link
Member

@HaripriyaB please take a look at #119 PR so you can see what you were possibly missing from your solution :)

@darahask
Copy link

Can I solve this issue please, Thankyou

@techno-disaster
Copy link
Contributor Author

Can I solve this issue please, Thankyou

Hi this is fixed in #119

@darahask
Copy link

darahask commented Sep 15, 2020

Understood related Pr hasn't been merged yet, Thank you.
Any other feature or issue I can work upon @techno-disaster.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Bug Bug or Bug fixes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants