Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sign in with github #1119

Open
1 of 3 tasks
vj-codes opened this issue Jun 1, 2021 · 15 comments
Open
1 of 3 tasks

implement sign in with github #1119

vj-codes opened this issue Jun 1, 2021 · 15 comments
Assignees
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.

Comments

@vj-codes
Copy link
Member

vj-codes commented Jun 1, 2021

Description

As a developer,
I need to add login with GitHub feature to app,
so that I can allow users to use their GitHub OAuth.

Implement login with GitHub to mentorship system

https://docs.github.com/en/developers/apps/building-oauth-apps/authorizing-oauth-apps

Acceptance Criteria

Update [Required]

  • A user is able to login into the platform with GitHub OAuth

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

???

@vj-codes vj-codes added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: Available Issue was approved and available to claim or abandoned for over 3 days. Type: Enhancement New feature or request. labels Jun 1, 2021
@vj-codes
Copy link
Member Author

vj-codes commented Jun 1, 2021

I would like to work on this

@epicadk
Copy link
Member

epicadk commented Jun 1, 2021

On my phone so can't assign for some reason. Please self assign.

@vj-codes vj-codes self-assigned this Jun 2, 2021
@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jun 2, 2021
@vj-codes
Copy link
Member Author

vj-codes commented Jun 2, 2021

On my phone so can't assign for some reason. Please self assign.

afaik the github app doesn't include that feature yet, you would need to use the browser on phone to do the same

@vj-codes
Copy link
Member Author

vj-codes commented Jun 6, 2021

@isabelcosta @epicadk for this there will be a need to create an OAuth app on Github that will give me client secret and client id which I can create for now from my acc but later the org acc will need to do the same
Is that alright?

@vj-codes
Copy link
Member Author

Update : was kinda busy with exams still working on it, got a few questions will ask in the sync up session if I don't find a solution about them on StackOverflow before the session 🚀

@devkapilbansal
Copy link
Member

@vj-codes any updates?

@vj-codes
Copy link
Member Author

Oops I forgot about this 😄
Making it available as I can't work on it right now :)

@vj-codes vj-codes removed their assignment Jul 10, 2021
@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jul 10, 2021
@isabelcosta
Copy link
Member

Thank you @vj-codes for updating the issue 🙌🏾

@lem0n4id
Copy link

Hey, i would like to work on this.

Can anyone please list out what all needs to be done to Implement login with GitHub to mentorship system?
I am new here

@lem0n4id
Copy link

hello, sorry for pinging everyone in this conversation.
i will not be able to work on this as i am not familiar with flask

@isabelcosta
Copy link
Member

No worries @lem0n4id in case it helps:

Feel also free to look other issues that can ease your way into the app ;)

@sukesh2000
Copy link

Is this issue still open, can I work on this? I've experience with implementing OAuth2 in NodeJS & Flask.

@devkapilbansal devkapilbansal removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Aug 2, 2021
@devkapilbansal
Copy link
Member

@sukesh2000 yes you can work on this. I have assigned this issue to you. Feel free to move forward and ask here or on Zulip if you have some doubts.
Happy Coding 😃

@sukesh2000
Copy link

sukesh2000 commented Aug 2, 2021

Thank you so much, I'll start working on it! I've joined Zulip as well, if I've any doubts then I'll put there.

@vj-codes
Copy link
Member Author

Any updates @sukesh2000 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

6 participants