Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added medium link #1186

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

eleensmathew
Copy link

Description

Added medium link

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@isabelcosta
Copy link
Member

@eleensmathew could you please put a screenshot of this working? Could you run the docusaurus website and put the image in the PR description?

@eleensmathew
Copy link
Author

eleensmathew commented Feb 9, 2022

The Medium icon is not available in font awesome 4.1.0 icons list ( source: https://www.adfwebmagazine.jp/wp-content/uploads/test_v4.1.pdf)
And this is why the medium icon doesn't show up in the webpage.

code sample
screenshot

Please let me know how I should proceed or if I have made a mistake,

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eleensmathew
Copy link
Author

Ok thanks a lot 👍

Copy link
Member

@vj-codes vj-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eleensmathew hey any update on this?

@eleensmathew
Copy link
Author

I think you should pass this onto someone else since my schedule is kind of busy at the moment. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants