Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all current failing Espresso Tests pass #704

Open
devansh-299 opened this issue May 9, 2020 · 26 comments
Open

Make all current failing Espresso Tests pass #704

devansh-299 opened this issue May 9, 2020 · 26 comments
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Testing UI Tests, Integration Tests, Travis CI, etc.

Comments

@devansh-299
Copy link

devansh-299 commented May 9, 2020

Describe the bug
After updating the .travis.yml in the PR #696 - link, many UI tests are failing (detailed report is here). The tests themselves or the code needs to be updated so that the tests do not fail and ultimately the build.

To Reproduce
Steps to run the tests locally

  1. Connect Android device or open the emulator
  2. On terminal type ./gradlew clean build connectedAndroidTest --stacktrace
  3. Wait for the tests to complete
  4. See the complete report ../mentorship-android/app/build/reports/androidTests/connected/index.html

Expected behavior
The Espresso tests shouldn't have failed

Smartphone (device on which the tests ran):

  • Xiaomi PocoF1
  • Android 10

Additional context
Add any other context about the problem here.

@devansh-299 devansh-299 added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Testing UI Tests, Integration Tests, Travis CI, etc. labels May 9, 2020
@isabelcosta
Copy link
Member

@devansh-299 thank you for creating this :) Are you interested in working on this, or leave it for another contributor? Either way is fine, i just want to know if it should be assigned to you or labeled as available

@isabelcosta isabelcosta added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label May 10, 2020
@devansh-299
Copy link
Author

@isabelcosta My experience with UI testing is not so good 😅 . Please label it as available

@isabelcosta
Copy link
Member

My UI testing is not very good as well 🙈

@Priyansh-Kedia
Copy link
Contributor

Hello @devansh-299
Can you please explain the issue?
I do not quite understand it.

@isabelcosta isabelcosta pinned this issue Jul 19, 2020
@anna4j
Copy link

anna4j commented Aug 22, 2020

@devansh-299 Could you please add a few resources so that contributors can take this up? Thanks

@isabelcosta isabelcosta changed the title Espresso Tests Failing Make all current failing Espresso Tests pass Aug 23, 2020
@isabelcosta
Copy link
Member

@anna4j I tried to change the title to make this more clear, this is about making the tests which are failing pass.

@isabelcosta
Copy link
Member

isabelcosta commented Aug 25, 2020

@devansh-299 does this command./gradlew clean build connectedAndroidTest --stacktrace run the Android Espresso tests (user interface tests)?

@anna4j
Copy link

anna4j commented Aug 30, 2020

@rpattath Hey! Is this issue supposed to be closed too since we're opening smaller UI Espresso test issues already?

@rpattath
Copy link
Member

@anna4j no this is for the current failing tests which is a still an issue. This issue was closed and broken down to smaller issues for new espresso tests to be added.

@justdvnsh
Copy link
Contributor

Hi. @rpattath @anna4j . I'd like to take up the task. Can I be assigned this issue ?

@iofall
Copy link

iofall commented Sep 2, 2020

We could split this up as well, there are about 8 tests that are failing. 1 test for the SignUpActivity and 7 tests for the LoginActivity

@justdvnsh
Copy link
Contributor

@iofall Yes. We can make one issue for Signup tests and one for login tests

@isabelcosta
Copy link
Member

@iofall that is a nice idea :) if you could create those issues and link it here in a comment that would be amazing

@anna4j anna4j added Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. and removed Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Sep 3, 2020
@iofall
Copy link

iofall commented Sep 16, 2020

@isabelcosta I have created these issues #868 and #918. Sorry I got late for this. Initially, I was planning on creating individual issues for each failing test, but that increased the complexity. Additionally, I discovered that some of the tests run successfully when run individually but fail when run as a whole. So I have just separated this issue into LoginActivityTest and SignUpActivityTest.

Let me know if any changes needed.

@isabelcosta
Copy link
Member

@iofall I think the tests are now fixed, can you or anyone else confirm that all tests are passing please?

Also, you did an amazing job separating the issues, that helps a LOT @iofall 👏 🎉 Thank you so much for helping out!

@epicadk
Copy link
Member

epicadk commented Oct 26, 2020

@iofall I think the tests are now fixed, can you or anyone else confirm that all tests are passing please?

Also, you did an amazing job separating the issues, that helps a LOT @iofall 👏 🎉 Thank you so much for helping out!

All sign up tests are passing but the login tests need to be changed as discussed on Zulip.

@kartikeysaran
Copy link
Contributor

This issue should be updated as currently we have removed the Travis CI from our code

@epicadk
Copy link
Member

epicadk commented Feb 20, 2021

This issue should be updated as currently we have removed the Travis CI from our code

@kartikeysaran nice catch. @devansh-299 can you update the issue?

@isabelcosta
Copy link
Member

Actually, at the time it was travis CI, changing the description not mentioning travis would not be true. This issue still represents the major priority which is having tests passing.

@devansh-299
Copy link
Author

@epicadk @isabelcosta if Travis CI has been removed and if needed, I can update the description of this issue to meet the current status of UI tests. Please let me know if any changes are to be made.

@justdvnsh
Copy link
Contributor

@isabelcosta @epicadk Any updates on this ? Let's get this over with !

@epicadk
Copy link
Member

epicadk commented Mar 4, 2021

@isabelcosta @epicadk Any updates on this ? Let's get this over with !

Yes the prs have been created they only need to be reviewed.

@justdvnsh
Copy link
Contributor

@epicadk Then, I'll review them in the coming days. Let's get this issue over with, since this issue has been opened for way too long now !

@epicadk
Copy link
Member

epicadk commented Mar 4, 2021

@epicadk Then, I'll review them in the coming days. Let's get this issue over with, since this issue has been opened for way too long now !

I'll link the pr's here #817 #1099

@justdvnsh
Copy link
Contributor

Thanks. Will update about them on Zulip.

@kartikeysaran
Copy link
Contributor

@epicadk Then, I'll review them in the coming days. Let's get this issue over with, since this issue has been opened for way too long now !

I'll link the pr's here #817 #1099

Reviewed the PR's LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. Type: Testing UI Tests, Integration Tests, Travis CI, etc.
Projects
None yet
Development

No branches or pull requests

10 participants