Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toast message when no user with common skills is found using filter #866

Open
vj-codes opened this issue Sep 6, 2020 · 26 comments · May be fixed by #1207
Open

Add toast message when no user with common skills is found using filter #866

vj-codes opened this issue Sep 6, 2020 · 26 comments · May be fixed by #1207
Assignees
@abhilipsasahoo03
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. First Timers Only Good for newcomers. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days.

Comments

@vj-codes
Copy link
Member

vj-codes commented Sep 6, 2020

Is your feature request related to a problem? Please describe.
When a user tries to filter members feature using Skills and no member is found after filtering ,
only a blank screen is displayed .

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Members page'
  2. Click on 'Filter'>> 'Skills'>> 'Type documenting' and apply
  3. See error

Describe the solution you'd like
Add a proper toast message like Opps! No member found. on the blank screen which is displayed .
@vj-codes vj-codes added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days. labels Sep 6, 2020
@sharur7
Copy link
Contributor

sharur7 commented Sep 6, 2020

I want to work on this issue

@Mrinmoy-Aus
Copy link

can this task be assigned to me?

@ritvij14
Copy link

ritvij14 commented Sep 7, 2020 •
edited
Loading

@vj-codes I haven't been assigned any issue yet, can I please take this one?

@Mrinmoy-Aus
Copy link

@vj-codes I cam completed my previous task can this be assigned to me?

@vj-codes
Copy link
Member Author

vj-codes commented Sep 7, 2020

Assigning you @ritvij14
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Sep 7, 2020
@ritvij14
Copy link

ritvij14 commented Sep 7, 2020

@vj-codes I have a doubt since this is given 2 category tags, will it be counted for both or for one only? For Open Source Hack.

@vj-codes
Copy link
Member Author

vj-codes commented Sep 7, 2020

This will come under coding @ritvij14
User interface is added as an additional category ,so that it's easy to understand.
UI issues for OSH are mostly redesigning the app

@ritvij14
Copy link

ritvij14 commented Sep 7, 2020

@vj-codes alright. Thanks for the clarification

@ritvij14
Copy link

ritvij14 commented Sep 7, 2020

@vj-codes I have just started exploring this project and this is my first issue so I thought I should confirm before sending the PR.
In the Members.kt file, the updateUserList() function uses the getFilteredUsers() function to get a list of users according to the filters in the search query.
In this, I see if-else conditions for checking filters like location and skills, so is this the part where I put a Toast for skills?

Please tell if I am proceeding in the right direction.

@vj-codes
Copy link
Member Author

vj-codes commented Sep 8, 2020

yes @ritvij14

@ritvij14 ritvij14 mentioned this issue Sep 10, 2020
Closed
5 tasks
@aditmehta9
Copy link
Member

@ritvij14 are you still working on this issue?

@vj-codes
Copy link
Member Author

@aditmehta9 #884 was created by @ritvij14 but then it was closed by the author and no update was made since then so making the issue available again
@aditmehta9 thank you for asking the update:)

@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 14, 2021
@epicadk epicadk added the First Timers Only Good for newcomers. label Apr 14, 2021
@amlannandy
Copy link

@epicadk Hello! Can you please assign this to me?

@epicadk
Copy link
Member

epicadk commented Apr 23, 2021

@amlannandy done. Good luck.

@amlannandy
Copy link

@amlannandy done. Good luck.

Thanks!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Apr 23, 2021
@amlannandy
Copy link

@epicadk Hey. I might not be able to work on this right now due to some other engagements. Unassigning myself so that others interested can pick it up.

@amlannandy amlannandy removed their assignment Apr 26, 2021
@ayushi790
Copy link

Hii @vj-codes, I would like to work on this issue. Can you please assign it to me?

@vj-codes
Copy link
Member Author

Assigning you @ayushi790
Happy coding!

@vj-codes
Copy link
Member Author

@ayushi790 any updates here?

@SubhraPriyadarshinee
Copy link

Hey, is anyone working on this? The issue is still there with no update so I thought of asking. If not, can you assign it to me?

Thank You.

@vj-codes
Copy link
Member Author

Unassigning you @ayushi790 due to inactivity

@vj-codes
Copy link
Member Author

Assigning you @SubhraPriyadarshinee
Happy coding!

@SubhraPriyadarshinee
Copy link

Hello, I have made my PR #1173 , please check and tell if anything is wrong.

Closed
2 tasks
@siddhbhardwaj
Copy link

Hi, Can I work on this issue?

@vj-codes vj-codes added the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Jan 27, 2022
@abhilipsasahoo03
Copy link
Contributor

abhilipsasahoo03 commented Jul 6, 2022 •
edited
Loading

Hello, I'd like to work on this issue! @vj-codes kindly assign it to me

@vj-codes
Copy link
Member Author

Assigning you @abhilipsasahoo03
Happy coding!

@abhilipsasahoo03 abhilipsasahoo03 linked a pull request Jul 12, 2022 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhilipsasahoo03 abhilipsasahoo03

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Category: User Interface Improvements or additions to design. First Timers Only Good for newcomers. Open Source Hack Status: Available Issue was approved and available to claim or abandoned for over 3 days.
Projects
None yet
Milestone
No milestone