-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug : the application is not supposed to crash because of a server error #1175
Comments
Can someone validate this? @anitab-org/mentorship-testers Also if this is the case why doesn't this work? mentorship-android/app/src/main/java/org/anitab/mentorship/viewmodels/SignUpViewModel.kt Lines 29 to 35 in c069751
|
@epicadk although there is a try catch in the viewmodel, you have to add another one in the AuthManager and throw an exception in the catch scope |
Can i open a PR ? |
Sure |
Yes the issue is valid, @yveskalume thank you so much for reporting it :) |
Hey, Is this project still being maintained? |
Hey yes being maintained |
Do I need to setup the backend also to build & run this Android app? |
Hey no you can download the apk directly |
I build this project and run the app from Android Studio. |
Describe the bug
an internal error makes the application crash when a new user tries to signup
To Reproduce
Steps to reproduce the behavior:
Expected behavior
an error that something is wrong should be displayed without the application crashing
Smartphone (please complete the following information):
Additional context
this can be fixed by adding a try catch in the AuthDataManager (I've already tested and it worked)
The text was updated successfully, but these errors were encountered: