Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dependency Injection with hilt #1108

Closed
wants to merge 14 commits into from

Conversation

epicadk
Copy link
Member

@epicadk epicadk commented Mar 5, 2021

Description

Fixes #1106

Type of Change:

  • Code

Code/Quality Assurance Only

  • This change requires a documentation update (software upgrade on readme file)
  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Testing on local device.

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@epicadk
Copy link
Member Author

epicadk commented Mar 5, 2021

Execution failed for task ':app:lint'.
> Lint found errors in the project; aborting build.

Should I correct the lint warnings or can I just suppress them? ( These errors were already present in the app and have nothing to do with the pr)

@epicadk epicadk marked this pull request as ready for review March 5, 2021 17:46
@vj-codes vj-codes added the Status: Needs Review PR needs an additional review or a maintainer's review. label Mar 5, 2021
@epicadk epicadk added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Apr 1, 2021
@epicadk epicadk marked this pull request as draft May 22, 2021 19:08
@epicadk
Copy link
Member Author

epicadk commented Sep 19, 2021

As discussed with anna we won't be moving forward with this right now.

@epicadk epicadk closed this Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Changes Requested Changes are required to be done by the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Dependency injection with dagger/hilt
2 participants