-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Dependency Injection with hilt #1108
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should I correct the lint warnings or can I just suppress them? ( These errors were already present in the app and have nothing to do with the pr) |
vj-codes
added
the
Status: Needs Review
PR needs an additional review or a maintainer's review.
label
Mar 5, 2021
epicadk
added
Status: Changes Requested
Changes are required to be done by the PR author.
and removed
Status: Needs Review
PR needs an additional review or a maintainer's review.
labels
Apr 1, 2021
As discussed with anna we won't be moving forward with this right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1106
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Testing on local device.
Checklist:
Code/Quality Assurance Only