Test: Write test successful login user gets redirected to Homepage with username on main navbar

[mtreacy002]

Description

As a developer,
I need test if redirection post successful login works
so that I can make sure user who has successfully logged-in gets redirected to the homepage with the main navbar showing username of login user.

Mocks

Acceptance Criteria

Update [Required]

• Write tests using React Testing Library in the Login.test.js file
• test if user gets redirected to homepage with main navbar showing their username after successful login

Enhancement to Update [Optional]

NA

Definition of Done

• All of the required items are completed.
• Approval by 1 mentor.

Estimation

1 day

[Shashwati-tidke]

@meenakshi-dhanani Can I work on this issue?

[aastha985]

Hi! @mtreacy002 Can I work on this issue?

[mtreacy002]

sure @aastha985. Go ahead 👍.

[aastha985]

Hi! I had to update about the status in 3 days. Haven't been able to work on this yet. I will do it by the weekend. I hope that's fine.

[mtreacy002]

Yep, sure, @aastha985. Thank you for notifying us on your situation. Let me know if you need any help with the task.

[aastha985]

Yep, sure, @aastha985. Thank you for notifying us on your situation. Let me know if you need any help with the task.

Sure! Thanks😊

[mtreacy002]

Hi @aastha985 , I'll make this issue available again since you are now working on backend issue#70

[aastha985]

Sure! @mtreacy002

[rpattath]

Hi @mtreacy002, I would like to work on this but have no experience. Looking forward to learning something new.

[mtreacy002]

Sure, @rpattath , I'll assign you to this. Let me know if you are facing any issue. we can try work it out together 😉

[somayaj]

Can this be worked?

[mtreacy002]

@rpattath , are you still working on this issue? Can you please give me an update?

[mtreacy002]

Update. This issue is now open to anyone that would like to work on it.

[nlok5923]

@mtreacy002 can you please assign this issue to me.

[Aaishpra]

@nlok5923 you are already assigned to #131 and according to the guidelines you can be assigned to only one issue at a time in a Repo. So, wait patiently until your PR gets reviewed and merged to claim other issues.😄

[Bucky25]

@mtreacy002 i would like to give it a go .

[emmanuelhashy]

No, I am not.

…

On Thu, 25 Feb 2021, 04:13 Maya Treacy, ***@***.***> wrote: @jalajcodes <https://github.com/jalajcodes> , since there's no update from @emmanuelhashy <https://github.com/emmanuelhashy>, I'll make this issue available again. Let me know if you're still interested (that's if you're not currently working on other issues 😉). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKIM6RMYQTE4AKTH7A7W3TDTAW563ANCNFSM4OJXWTLA> .

[mtreacy002]

@emmanuelhashy, can you give us an update on this then?

[rkraeher]

@mtreacy002 Since this is available again, is this issue something doable for a first time contributor? There are currently no unassigned "first timer" issues available.

[mtreacy002]

@rkraeher, this issue might be a bit complicated for a first-timer. But if you have some experience in the tech stack and confident you can work on it, I can assign you to this. For their first contribution to the project, a contributor doesn't have to limit themselves to a First-timers only issue. That label is there to make sure that the issue is not too challenging for new contributors who might not have the background on the tech stack.

So, let me know if you do want to work on this 😉

[rkraeher]

ok thank you. I have experience with React and jest. I looked at the Login.test file and briefly at the React Testing Library docs and I believe I can do it but I was wondering if I can get some clarification on the user story?

Right now there is one test for a successful login testing that an error message doesn't show up (lines 29-46 in Login.test). Am I on the right track to begin something like:

it('redirects the user after successful login,' async()=> {
// successful post request
render( <MemberPortfolio /> 
//Rest of the test
)}

[mtreacy002]

You're on the right target, @rkraeher . Would you like me to assign you to this?

[rkraeher]

great! yes can you please assign it to me? thanks!

[rkraeher]

If I'm having some trouble setting up the environment should I ask you here or get some help in Zulip?

[mtreacy002]

Done, I've assigned you on this @rkraeher . Yep, if you are facing trouble setting up, please reach out to us. Zulip will be a better option for trouble related to setting up, since you'll reach a wider audience compared to here on GitHub. Others who might have experienced the same issue can suggest a solution based on their experience. The post will also be helpful to other contributors that also trying to set up their project. So, I always encourage people to ask questions on zulip for issues related to setting up 😉.

[mtreacy002]

@rkraeher , any update on this issue?

[rkraeher]

Sorry for the delayed response. I wrote some of this on Zulip but with your help I managed to get the app running in the browser but there is now another missing module error that I need to figure out so I'm still working on getting my environment set up.

[rkraeher]

missing module: psycopg2._psycopg

[mtreacy002]

@rkraeher perhaps try installing psycopg2 separately (after the initial dependencies install through requirements.txt) as suggested by @vj-codes here (point 2). Let me know if it works.

[rkraeher]

@mtreacy002 Ok I did as you suggested, installed psycopg2 separately, and it is now working. I will now proceed to link up BIT with MS so I have both servers running.

[mtreacy002]

@rkraeher , any updates on this issue?

[rkraeher]

@mtreacy002 I now have successfully set up both servers and have the frontend site up locally. Starting today I can begin working on writing the test.

[mtreacy002]

@rkraeher , any updates on this issue?

[mtreacy002]

Putting this on hold following discussion with the contributor on zulip

[rkraeher]

hey there @mtreacy002. i'm feeling better and was interested in getting involved again on the project during hacktober. Can I get back to work on this issue? Or if there are other areas where contribution would be more helpful im flexible and open to suggestion :)

[vj-codes]

@rkraeher welcome back 🎉
Removing the issue from 'hold' and you can work on it, have a great start :)

[rkraeher]

hi @vj-codes and @mtreacy002 I finally managed to open the PR for this. sorry for the delay. Tagging you both here since the zulip stream seems a bit stale.