UI:Implemented Why BIT section #247
Conversation
There was a problem hiding this comment.
@DhaneshShetty , can you please resolve the conflict? It must be resulted by the recent merge so you can pull the latest update on develop branch. Thanks
|
Hi @DhaneshShetty , the failing tests here is the result of unused user variable pointed out by @Rahulm2310 on pr #246. Once that pr is approved and merged, you should be able to fix the error tests here by pulling the latest update from |
There was a problem hiding this comment.
Hi @DhaneshShetty , thank you for your work on this issue. I'm sorry for the delay in the feedback. Just some minor change from my end. I've pointed out the trigger for the error you faced on the tests in the previous comment. So, keep an eye on #246 progress and pull the fix one that pr is merged. Also, check my comment below on the font-weight 😉.
|
@DhaneshShetty , can you please give us update on this? |
mtreacy002
added
Category: User Interface
|
@mtreacy002 Sorry for the delay.I have done the necessary changes. |
There was a problem hiding this comment.
@DhaneshShetty . The test is now failing because you forgot to import WhyBit component on top of the Home.jsx file. Can you please fix this? Thanks 😉
|
@DhaneshShetty , thank you for fixing the failing test. The tests passed now, but can you please resolve the conflict? It must be from the recent commits to the develop branch. Thanks |
There was a problem hiding this comment.
@DhaneshShetty , I could see 2 sections (duplication) of WhyBIT section in your latest code. Can you please remove one? Thanks
|
@mtreacy002 I just noticed that this section has been implemented in the latest PR along with the video section.Should I remove that or close my PR? |
|
Oops, sorry @DhaneshShetty, I didn't realised it. Yeah, perhaps it's best to close this PR for now since we already have the section in the existing code. Sorry for the inconvenience 🙏. |
Description
Developed WhyBIT section UI of the Home page.
Fixes #209
Type of Change:
How Has This Been Tested?
Checklist:
Code/Quality Assurance Only