-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: Update react-scripts dependency to remove high severity vulnerabilities #194
Comments
@mtreacy002 I have added the |
I would like to work on this issue. |
Assigning @Anmollenka. |
@mtreacy002 just wanted to confirm if medium severity vulnerabilities should be removed too? |
@Amulya-coder Can you just confirm so that I can create a pull request. |
@Anmollenka, Yes you can go ahead and create a pull request no need to worry about medium severity vulnerabilities. |
@Anmollenka any updates here? |
Will create a pr within an hour |
@vj-codes After manually changing the versions 2 high vulnerabilities are still there. |
@Anmollenka , can you please show us steps you've done along with the log on a gist of npm audit report? This will help us better understand the issue you are facing. Thanks 😉 |
sure @mtreacy002 |
@mtreacy002 I updated the react version to 4.0.3 and ran npm audit.Here is the gist of the npm audit report. |
@Anmollenka , when you said you've manually changed the versions, which versions you're talking about? for example, I can't see how you've updated react version to 4.0.3 while the version stated inside package.json is 16.3.1. can you please submit the PR with whatever you currently have so that we could see what you have done and how we can improve this? thanks |
Yes @mtreacy002 as I have not submitted my pull request you will not be able to see my changes.Sorry for the inconvenience caused by not explaining my approach properly. |
Is your feature request related to a problem? Please describe.
The current react-scripts dependency (v3.4.3) is causing 2 high severity warnings
Describe the solution you'd like
Update react-scripts dependency from 3.4.3 to 4.0.3. Note: this install involves potential breaking changes.
While on it, fix other vulnerability warnings as well.
Describe alternatives you've considered
Ignore warnings if they don't causing major issue
Additional context
These warnings were caught on the initial dependencies installation of a newly cloned project.
Here's the gist of npm audit reports.
The text was updated successfully, but these errors were encountered: