-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Utilise flask-migrate to support SQLAlchemy migration using alembic #211
Comments
@mtreacy002 now it's open to OSH contributors they'll surely pick this issue. |
@Amulya-coder , would this be a bit hard for the new contributors? I'm not sure if it's a good idea to open it as OSH issue. 🤔. |
Agreed it doesn't seem like a good issue for OSH |
@mtreacy002 I can give it a try |
Ok, @decon-harsh , you can pick up the issue. Thank you 😉 |
@decon-harsh , I've shared the files I worked on before in the issue description. Feel free to ask anything if you're in doubt. |
Hey @mtreacy002 need some help When I followed the docs and made migration Tables of only public schema were getting created. Why is it happening? I used your gist, the upgrade & downgrade function only had pass. So I was unable to get the exact idea of what was happening. |
🤔. It seems like we cannot avoid recreating the db from scratch if we want to have the correct schema. I don't think it's a bad idea considering we still in very early stage of development. |
There is an issue regarding that @mtreacy002 i cannot upgrade that migration because in line 67 there is more than 255 arguments getting passed which throws that error , however when I checked about it and it said it was removed in python3.7 version but i was using that only. Now I have to pass it as a list there. Thanks |
Is your feature request related to a problem? Please describe.
At the moment BIT backend doesn't have db migration management. This will cause issue in case we have to alter the database schemas.
Describe the solution you'd like
Utilise flask-migrate to handle SQLalchemy schemas migration using Alembic.
Describe alternatives you've considered
To simplify migration script, bit and ms schema can be integrated as one schema. This is only possible when the idea proposed on zulip discussion is approved (to fully integrate BIT backend into MS backend).
Additional context
The migration script/s should be able to handle the multiple schemas accordingly.
I have attempted this before using the following files (while the initial migration was successfully created, there's still work to be done like sorting out how to read the changes made to bit_schema)
The text was updated successfully, but these errors were encountered: