-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a section of home page #134
Conversation
@raksh543 please separate this to 4 sections and each section should follow our implementation guide. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raksh543 please separate this to 4 sections and each section should follow our implementation guide. Thanks.
@raksh543 I have applied the changes, can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@annabauza I have reviewed the changes.
It looks good.
@raksh543 the PR has been merged so you can reuse TextImage component. Please prepare testing page by following the guide https://github.com/anitab-org/anitab-org.github.io/wiki/Prepare-testing-GitHub-Pages-for-your-PR |
@annabauza Please check the preview of the webpage, if it looks fine now i will proceed. |
@annabauza Please review the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- No need to add other fonts,
- image requests should come from content - look on how other code parts are solving it - replace json with js file
- page should not display on each tab - only when you press on AnitaB logo (if case 0 in Content.js)
- use styled view like aboutus/styles.js
- use mapper instead of create each section file separately.
- remove dependency which you have added.
const {sections} = contentJson; | ||
var content =""; | ||
|
||
sections[0].content.forEach(text=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please pass section as a prop
var content =""; | ||
|
||
sections[0].content.forEach(text=>{ | ||
content += text.par+"\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep paragraphs as stack of texts instead of adding '\n'
@annabauza I am working on these changes. |
@annabauza I have made all changes as requested. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raksh543 thank you for this PR, I have added those sections can you please update the images on home page? Thanks!
@raksh543 can u do the changes?? |
@nandini45 Sure i will do the changes. Please tell me which which images i am supposed to change. |
@anna4j Any update on this PR? I can see this PR contains many conflicting files. Please resolve conflicts and you can squash your 19 commits to single commit. Thanks !! |
closing this issue because getting started already exists. |
Description
Added the home section of Getting started, ways to contribute, our projects and open source programs
Fixes #110
Type of Change:
Delete irrelevant options.
Code/Quality Assurance Only
How Has This Been Tested?
I have checked the responsiveness by resizing window.
Landscape view:
Potrait view:
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only