@iamkryptonite @nandini45 please review the solution i approached for resolving the issue.

@nlok5923 the current date is still being shown in the wrong place. Also you can use gh-pages to deploy instead of heroku.

@iamkryptonite as today is 7th of march so it is showing:

which is quite near to marker for date 1 march which says today's date is 7th march.

please correct me @iamkryptonite if am missing something.

@nlok5923 if you scroll at the very beginning you will see this.

7th of March(todays date) is being shown in the month of January. It should be in March. And according the Fade and Marker component will be adjusted.

@iamkryptonite please can you test the deployed site again i think the changes are addressed in latest commit:

@nlok5923 the timeline is overlapping the program title


Please fix this.

Thanks @Rahulm2310 for pointing out the issue will resolve it in the latest commit.

@Rahulm2310 i think you were testing it at custom resolution as it will definitely throws some distortion in custom resolution as here positioning has been made using date value

@iamkryptonite can you suggest me some clue to bring dynamicity in positioning.

For now maybe keep the Events component fixed at the very beginning and adjust the other components so that they don't overlap in smaller resolutions. Use both date and month to adjust the positions like its done in the Date component and tweak it a little bit. Hope this helps.

Also the line component should start from the first given date for each individual event.

changes in latest commit:

• Event components now have fix position.
• line start from start date of year
  
  

@iamkryptonite please can you review the changes

@nlok5923 Looks good just a few small changes:

1. For smaller screens the "events" are still overlapping with the dates. To test this go to inspect elements, then toggle device toolbar(phone/tablet icon) and select Laptop-1024px.
2. When the component is loaded try to keep the current date in the middle.
3. Add some padding between the marker and the current date .
4. Add a few more dummy dates if possible.

@iamkryptonite the dates for events in timelines are actual ones i think we can't put dummy dates there. Also i still doubt how can we stop overlapping of event components with date in smaller resolution. the event component has fixed size so do i need to alter the size of event component or i need to do something else to make it dynamic .

rest points will get address in latest commit.

changes in latest commit:

removed overlapping at smaller resolutions .

test deployment here: https://hardcore-booth-457055.netlify.app/

Looks good!

@annabauza can u please review this pull request.

@annabauza can u please review this pull request.

Approved require one more review

I don't quite understand the change here. I don't understand the diagram 😳 @iamkryptonite if you approve this if you think it looks good I am happy to merge this. We just need a second approval

@nlok5923 could you fix the merge conflicts, please?

@isabelcosta i will open a new pr for this changes as i need to close this pr due to force push.